Skip to content

Commit

Permalink
Switched to the latest version of Eigen that performs much better on …
Browse files Browse the repository at this point in the history
…machines

with many cpu cores

For example, the wall time for the following tutorial went down from 13m35 to 5m27:
bazel run -c opt --copt=-mavx tensorflow/examples/tutorials/word2vec/word2vec_basic
Change: 122462177
  • Loading branch information
benoitsteiner authored and mrry committed May 17, 2016
1 parent 8991c7e commit ab02c5a
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion eigen.BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

archive_dir = "eigen-eigen-aaa010b0dd40"
archive_dir = "eigen-eigen-a5e9085a94e8"

cc_library(
name = "eigen",
Expand Down
4 changes: 2 additions & 2 deletions tensorflow/contrib/cmake/external/eigen.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

include (ExternalProject)

set(eigen_archive_hash "aaa010b0dd40")
set(eigen_archive_hash "a5e9085a94e8")

set(eigen_INCLUDE_DIRS
${CMAKE_CURRENT_BINARY_DIR}
Expand All @@ -16,7 +16,7 @@ set(eigen_INCLUDE_DIRS
${tensorflow_source_dir}/third_party/eigen3
)
set(eigen_URL https://bitbucket.org/eigen/eigen/get/${eigen_archive_hash}.tar.gz)
set(eigen_HASH SHA256=948cccc08e3ce922e890fe39916b087d6651297cd7422a04524dbf44e372ed9a)
set(eigen_HASH SHA256=967126237829c7c87abb6cd0e13a5a235b0377d51575522c390b9486aed13e71)
set(eigen_BUILD ${CMAKE_CURRENT_BINARY_DIR}/eigen/src/eigen)
set(eigen_INSTALL ${CMAKE_CURRENT_BINARY_DIR}/eigen/install)

Expand Down
4 changes: 2 additions & 2 deletions tensorflow/workspace.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def tf_workspace(path_prefix = "", tf_repo_name = ""):

native.new_http_archive(
name = "eigen_archive",
url = "https://bitbucket.org/eigen/eigen/get/aaa010b0dd40.tar.gz",
sha256 = "948cccc08e3ce922e890fe39916b087d6651297cd7422a04524dbf44e372ed9a",
url = "https://bitbucket.org/eigen/eigen/get/a5e9085a94e8.tar.gz",
sha256 = "967126237829c7c87abb6cd0e13a5a235b0377d51575522c390b9486aed13e71",
build_file = path_prefix + "eigen.BUILD",
)

Expand Down
2 changes: 1 addition & 1 deletion third_party/eigen3/Eigen/Cholesky
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/Eigen/Cholesky"
#include "eigen-eigen-a5e9085a94e8/Eigen/Cholesky"
2 changes: 1 addition & 1 deletion third_party/eigen3/Eigen/Core
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/Eigen/Core"
#include "eigen-eigen-a5e9085a94e8/Eigen/Core"
2 changes: 1 addition & 1 deletion third_party/eigen3/Eigen/Eigenvalues
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/Eigen/Eigenvalues"
#include "eigen-eigen-a5e9085a94e8/Eigen/Eigenvalues"
2 changes: 1 addition & 1 deletion third_party/eigen3/Eigen/LU
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/Eigen/LU"
#include "eigen-eigen-a5e9085a94e8/Eigen/LU"
2 changes: 1 addition & 1 deletion third_party/eigen3/Eigen/QR
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/Eigen/QR"
#include "eigen-eigen-a5e9085a94e8/Eigen/QR"
2 changes: 1 addition & 1 deletion third_party/eigen3/unsupported/Eigen/CXX11/Tensor
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#include "eigen-eigen-aaa010b0dd40/unsupported/Eigen/CXX11/Tensor"
#include "eigen-eigen-a5e9085a94e8/unsupported/Eigen/CXX11/Tensor"

0 comments on commit ab02c5a

Please sign in to comment.