Skip to content

Commit

Permalink
Merge pull request #49320 from geetachavan1/cherrypicks_TJJGE
Browse files Browse the repository at this point in the history
Fix `tf.raw_ops.ResourceCountUpTo` null pointer dereference.
  • Loading branch information
mihaimaruseac committed May 20, 2021
2 parents 2a72d97 + 6d732ab commit db88764
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tensorflow/python/lib/core/ndarray_tensor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ limitations under the License.
#include "tensorflow/python/lib/core/ndarray_tensor.h"

#include <cstring>
#include <optional>

#include "tensorflow/core/lib/core/coding.h"
#include "tensorflow/core/lib/core/errors.h"
Expand Down Expand Up @@ -72,6 +73,13 @@ Status PyArrayDescr_to_TF_DataType(PyArray_Descr* descr,
PyObject* key;
PyObject* value;
Py_ssize_t pos = 0;

// Return an error if the fields attribute is null.
// Occurs with an improper conversion attempt to resource.
if (descr->fields == nullptr) {
return errors::Internal("Unexpected numpy data type");
}

if (PyDict_Next(descr->fields, &pos, &key, &value)) {
// In Python 3, the keys of numpy custom struct types are unicode, unlike
// Python 2, where the keys are bytes.
Expand Down

0 comments on commit db88764

Please sign in to comment.