Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 199474340 #19816

Merged
merged 42 commits into from
Jun 6, 2018
Merged

Branch 199474340 #19816

merged 42 commits into from
Jun 6, 2018

Conversation

drpngx
Copy link
Contributor

@drpngx drpngx commented Jun 6, 2018

No description provided.

shashishekhar and others added 30 commits June 5, 2018 10:22
PiperOrigin-RevId: 199316885
This bug seems to be specific to tf.keras, i.e., it doesn't happen to keras.

PiperOrigin-RevId: 199334073
less logging.

PiperOrigin-RevId: 199334548
PiperOrigin-RevId: 199335030
PiperOrigin-RevId: 199340127
… for TPUEstimator.

PiperOrigin-RevId: 199341721
new_cond is a new implementation of tf.cond. Instead of emitting
control flow ops (i.e. Switch and Merge nodes), new_cond emits a
single If op, which represents the conditional branches as TF
functions.

With this change, users can use new_cond and take its gradient.

The idea is for new_cond to eventually replace tf.cond. There are
several functional and performance gaps that must be addressed first,
including:
* Gradients won't work on imported graphs
* Misc. limitations of TF functions (lack of collections, device scopes, etc.)
PiperOrigin-RevId: 199346735
PiperOrigin-RevId: 199347316
…duction init_value.

PiperOrigin-RevId: 199350818
DistributionStrategy, since it depends on the session. Drop
"job:localhost" when canonicalizing in graph mode.

PiperOrigin-RevId: 199354215
PiperOrigin-RevId: 199361276
PiperOrigin-RevId: 199361402
PiperOrigin-RevId: 199366963
PiperOrigin-RevId: 199372205
PiperOrigin-RevId: 199373124
… change the interface to be able to describe the common AllReduce semantic.

PiperOrigin-RevId: 199376926
This is useful when tuning fusion heuristics -- you expect this number
to go down (even if the total runtime doesn't go down, due to suboptimal
emitters).

PiperOrigin-RevId: 199386923
Michael Case and others added 12 commits June 5, 2018 17:50
…KSPACE.

These rules currently get written by configure.py script to WORKSPACE
file which is not ideal since (1) WORKSPACE file is tracked by git and
(2) we require users to manually delete the rules in order to
update/regenerate them.

Moving these rules into an external repo that is generated based on
several ENV variables set by the configure.py script. Modifying any
of these ENV variables will cause the rules to be updated.

PiperOrigin-RevId: 199388460
PiperOrigin-RevId: 199395164
PiperOrigin-RevId: 199399375
PiperOrigin-RevId: 199405764
Mostly just cosmetic refactoring to make PartitionedCallOp more readable; also registers a GPU kernel.

PiperOrigin-RevId: 199433460
…this is now properly supported in the Text Format.

PiperOrigin-RevId: 199450074
PiperOrigin-RevId: 199464493
PiperOrigin-RevId: 199465056
It was not explicitly stated that the predicate should return True for elements the user wants to keep.

PiperOrigin-RevId: 199474340
@drpngx drpngx requested a review from yifeif June 6, 2018 16:44
@drpngx drpngx added the kokoro:force-run Tests on submitted change label Jun 6, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 6, 2018
@drpngx
Copy link
Contributor Author

drpngx commented Jun 6, 2018

Timeout, retrying (dataset_optimize_op_test).

@drpngx drpngx merged commit bef709a into tensorflow:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet