-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comparison between signed and unsigned integer #20428
Comments
Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks. |
Hi, Thank you for your help! |
I'm slightly confused what the issue is. Is the issue that TensorFlow has compiler warnings, and someone has changed a BUILD or bzl file to treat warnings as errors? If so, what was done to treat warnings as errors? Also for future reference, you should always fill out the form, since we might not respond to issues if the form is not filled out. |
When used the compiler flag, -Werror, I cannot compile Tensorflow. JW |
Unfortunately, there are lots of TensorFlow warnings, so it would be difficult to remove all of them. /CC @gunan, any plans to remove the TensorFlow warnings? If not, can you mark as contributions welcome? |
Marking as contributions welcome to remove warnings, since no one internally is working on it. |
Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the |
When building a CPP API application with "-Wall -Werror" option , `error: comparison between signed and unsigned integer expressions' occurs since return type of num_elements() is 'int64' instead of 'size_t' in ops.h to express -1. This patch fixes this bug by explicit type casting. * related issue: tensorflow#20428 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
When building a CPP API application with "-Wall -Werror" option , `error: comparison between signed and unsigned integer expressions' occurs since return type of num_elements() is 'int64' instead of 'size_t' in ops.h to express -1. This patch fixes this bug by explicit type casting. * related issue: tensorflow#20428 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
My RP is already merged so I think that this issue would be fixed. Could someone in charge close this issue? |
Closing, as @again4you fixed this in #21966. |
System information
No need. It is about comparison warning happening in cc/framework/ops.h
ops.h:153:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if (t.NumElements() != v.size()) {
cc1plus: all warnings being treated as errors
Unfortunately, due to policy out of my control,
I cannot change the compiler option to treat warning as an error.
I hope this to be fixed so that I can compile.
Describe the problem
Same as above.
Source code / logs
tensorflow/cc/framework/ops.h
The text was updated successfully, but these errors were encountered: