Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unchanging minibatches from skflow DataFeeder for unsupervised tasks #2159

Closed
mheilman opened this issue Apr 28, 2016 · 6 comments
Closed

unchanging minibatches from skflow DataFeeder for unsupervised tasks #2159

mheilman opened this issue Apr 28, 2016 · 6 comments

Comments

@mheilman
Copy link
Contributor

I'm pretty sure there's a bug here in the DataFeeder class for skflow (tf.contrib.learn). If there are no labels, then the mapping of input placeholders to inputs is returned without updating the minibatch offsets. The code for updating offsets and shuffling won't be reached.

@cssndrx
Copy link
Contributor

cssndrx commented Apr 29, 2016

Agreed that this looks like a bug. Thanks for the find!

Feel free to submit a pull request (I can also submit a fix :)

@mheilman
Copy link
Contributor Author

You're welcome. I just happened to come across it when looking at how the data feeders work. I don't think I'll have bandwidth for a PR in the near future, but I thought it'd be helpful to make note of it here.

@cssndrx
Copy link
Contributor

cssndrx commented Apr 29, 2016

Thanks again! I'll submit the fix :)

vrv pushed a commit to vrv/tensorflow that referenced this issue May 5, 2016
@mrry
Copy link
Contributor

mrry commented May 16, 2016

@cssndrx: Did this fix make it into the master branch?

@terrytangyuan
Copy link
Member

terrytangyuan commented May 16, 2016

@mrry I think so. Looks like you are adding that commit internally. 2c3c49b

@mrry
Copy link
Contributor

mrry commented May 16, 2016

Great, thanks!

@mrry mrry closed this as completed May 16, 2016
qbx2 pushed a commit to qbx2/tensorflow that referenced this issue May 25, 2016
fsx950223 pushed a commit to fsx950223/tensorflow that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants