Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third_party: update libjpeg-turbo to 2.0.0 #21993

Merged
merged 1 commit into from Sep 5, 2018

Conversation

perfinion
Copy link
Member

libjpeg-turbo-2.0.0 fixes CVE-2018-1152 and CVE-2018-11813

The build and source tree has been rearranged, the simd files are now in
subdirs.

Signed-off-by: Jason Zaman jason@perfinion.com

This obsoletes #21654. I have only tested amd64. Lets see how badly the tests fail for the other arches.

@perfinion perfinion self-assigned this Aug 31, 2018
@perfinion perfinion requested review from yifeif and gunan August 31, 2018 15:31
libjpeg-turbo-2.0.0 fixes CVE-2018-1152 and CVE-2018-11813

The build and source tree has been rearranged, the simd files are now in
subdirs.

Signed-off-by: Jason Zaman <jason@perfinion.com>
@perfinion
Copy link
Member Author

Looks like windows does not HAVE_BUILTIN_CTZL. The rest all passed, XLA failure looked unrelated.
@gunan @yifeif Does this PR look better than the patch one to fix libjpeg-turbo CVEs?

@perfinion
Copy link
Member Author

Yay the windows tests pass now too

@gunan
Copy link
Contributor

gunan commented Aug 31, 2018

This should be able to go in all automated. Sorry for the delay on the other one.
I will retrigger the tests.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 31, 2018
@gunan gunan assigned aaroey and unassigned perfinion Aug 31, 2018
@aaroey aaroey added the kokoro:force-run Tests on submitted change label Aug 31, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 31, 2018
@perfinion perfinion added the kokoro:force-run Tests on submitted change label Sep 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 1, 2018
@perfinion
Copy link
Member Author

@gunan I saw the r1.11 branch was just made. Can you make sure this gets in to that branch as well before the releases? We dont want any security risks in those.

@aaroey aaroey added the ready to pull PR ready for merge process label Sep 1, 2018
@gunan gunan added the kokoro:force-run Tests on submitted change label Sep 4, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 4, 2018
@perfinion perfinion added the kokoro:force-run Tests on submitted change label Sep 5, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 5, 2018
@tensorflow-copybara tensorflow-copybara merged commit 30d2046 into tensorflow:master Sep 5, 2018
tensorflow-copybara pushed a commit that referenced this pull request Sep 5, 2018
PiperOrigin-RevId: 211706322
@perfinion perfinion deleted the jpeg branch September 6, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants