-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bazel/MSVC] Enable jpeg SIMD for MSVC #20537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Nagging Assignee @martinwicke: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
I cannot tell how, but the failures look legit.
@rongjiecomputer could you conditionally add msvc.h to this list, maybe what will fix it? |
#21993 is going to break this PR again. Can we get this or that PR merged soon? |
@rongjiecomputer the update to 2.0.0 needs to go in quickly cuz it fixes some CVEs in the current version. That version passes all the tests but I don't really know how to do the SIMD stuff on windows. It looks like 2.0.0 adds quite a bit of support tho so ideally could you rebase this on top of the 2.0.0 one to enable the windows SIMD stuff? |
@perfinion I will rebase and update this PR when your PR is merged. It is just that all my Windows PRs tend to drag very long before it gets imported for some reason. Having to keep updating PR due to newer changes breaking my PR is pretty frustrating. |
@rongjiecomputer yep I hear you. Ping me when it's rebased and I'll help push it through. Thanks for the patience :-) |
f22edf3
to
1085a77
Compare
Can I get a CI test? Thanks! |
@rongjiecomputer Looks like some windows test failures. can you take a look? |
- Add config/msvc.h when building nasm on Windows - Update Windows SIMD for libjpeg-turbo 2.0.0 - Add missing source files
1085a77
to
d41f5ff
Compare
@perfinion Windows builds failed because symbols from I have squashed the commits as requested. I did not do it initially as I thought it will make it difficult for reviewer to see what I have changed since last review. |
PiperOrigin-RevId: 212085036
No description provided.