-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker] Upgraded images to Ubuntu 18.04 LTS. #23066
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA signed. |
CLAs look good, thanks! |
Looks good to me, but @gunan, is this safe to do? I don't know if there are any problems keeping us at 16.04. |
I think ubuntu 18.04 has python 3.7? |
Yes it has python 3.7 default but what are the python 3 docker images that are you talking about? |
Check also #17022 |
All the images that have "py3" suffix here: |
I will close this PR for now. |
@gunan Actually, 18.04 LTS has Python 3.6.6:
|
@bhack |
Mhh it is strange cause https://packages.ubuntu.com/bionic-updates/python3 gives 3.6.5 ... But apt wins |
So can we reopen this? |
@gunan Friendly ping. Can you please take a look at this PR? Thanks! |
Our Docker images are updated nightly as long as that nightly package builds (for the |
PiperOrigin-RevId: 222880110
Note that the GPU development images were not changed in this PR. nvidia/cuda doesn't provide Ubuntu 18 / cuda 9.0 base images. |
@angersson Is TF still default on 9.0? Any plan for 9.2? There was a bug in cuda 9.0 series with "modern" version of GCC>=6. Some Asan flags for cuda like |
Upgraded all Docker base images to
18.04
.I haven't upgraded the GPU ones as those are still marked experimental: https://hub.docker.com/r/nvidia/cuda/