Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Upgraded images to Ubuntu 18.04 LTS. #23066

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Oct 18, 2018

Upgraded all Docker base images to 18.04.

I haven't upgraded the GPU ones as those are still marked experimental: https://hub.docker.com/r/nvidia/cuda/

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jpds
Copy link
Contributor Author

jpds commented Oct 18, 2018

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

@ymodak ymodak self-assigned this Oct 18, 2018
@ymodak ymodak added the awaiting review Pull request awaiting review label Oct 18, 2018
@angerson
Copy link
Contributor

Looks good to me, but @gunan, is this safe to do? I don't know if there are any problems keeping us at 16.04.

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 19, 2018
@gunan
Copy link
Contributor

gunan commented Oct 21, 2018

I think ubuntu 18.04 has python 3.7?
If yes, i think this will break all our python 3 docker images.

@bhack
Copy link
Contributor

bhack commented Oct 23, 2018

Yes it has python 3.7 default but what are the python 3 docker images that are you talking about?

@bhack
Copy link
Contributor

bhack commented Oct 23, 2018

Check also #17022

@gunan
Copy link
Contributor

gunan commented Oct 23, 2018

All the images that have "py3" suffix here:
https://hub.docker.com/r/tensorflow/tensorflow/tags/

@gunan
Copy link
Contributor

gunan commented Oct 23, 2018

I will close this PR for now.

@gunan gunan closed this Oct 23, 2018
@jpds
Copy link
Contributor Author

jpds commented Oct 23, 2018

@gunan Actually, 18.04 LTS has Python 3.6.6:

$ apt-get install python3
$ python3
Python 3.6.6 (default, Sep 12 2018, 18:26:19)

@bhack
Copy link
Contributor

bhack commented Oct 23, 2018

@bhack
Copy link
Contributor

bhack commented Oct 23, 2018

@jpds
Copy link
Contributor Author

jpds commented Oct 23, 2018

@bhack python3 ultimately installs python3.6 which pulls in 3.6.6: https://packages.ubuntu.com/bionic-updates/python3.6

@bhack
Copy link
Contributor

bhack commented Oct 23, 2018

Mhh it is strange cause https://packages.ubuntu.com/bionic-updates/python3 gives 3.6.5 ... But apt wins

@bhack
Copy link
Contributor

bhack commented Oct 25, 2018

So can we reopen this?

@gunan gunan reopened this Oct 25, 2018
@ymodak
Copy link
Contributor

ymodak commented Nov 7, 2018

@gunan Friendly ping. Can you please take a look at this PR? Thanks!

@ymodak ymodak added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 12, 2018
@angerson angerson added the kokoro:force-run Tests on submitted change label Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 14, 2018
@angerson
Copy link
Contributor

angerson commented Nov 14, 2018

Our Docker images are updated nightly as long as that nightly package builds (for the nightly- images) and per-release (for latest- and XX.XX-), so if your deployment is time-critical and you only want to use stable releases, I'd recommend using your own image until these changes are deployed.

@tensorflow-copybara tensorflow-copybara merged commit 9cc0aeb into tensorflow:master Nov 26, 2018
frreiss pushed a commit to frreiss/tensorflow-fred that referenced this pull request Nov 26, 2018
@angerson
Copy link
Contributor

Note that the GPU development images were not changed in this PR. nvidia/cuda doesn't provide Ubuntu 18 / cuda 9.0 base images.

@bhack
Copy link
Contributor

bhack commented Nov 26, 2018

@angersson Is TF still default on 9.0? Any plan for 9.2? There was a bug in cuda 9.0 series with "modern" version of GCC>=6. Some Asan flags for cuda like protect_shadow_gap=0 are not avaialbe on gcc 5.x.

@angerson
Copy link
Contributor

@bhack As far as I know, the TF team is working on upgrading directly to CUDA 10. @tfboyd, can you weigh in?

@bhack
Copy link
Contributor

bhack commented Nov 26, 2018

#22706

@jpds jpds deleted the 18.04-docker branch September 11, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants