Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Reference Models: NMT Model (TPU with dist strat and Keras) #25432

Closed
dynamicwebpaige opened this issue Feb 1, 2019 · 8 comments
Closed
Assignees
Labels
comp:dist-strat Distribution Strategy related issues comp:tpus tpu, tpuestimator stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author TF 2.9 Issues found in the TF 2.9 release (or RCs) type:feature Feature requests

Comments

@dynamicwebpaige
Copy link
Contributor

Sequence-to-sequence (seq2seq) models (Sutskever et al., 2014, Cho et al., 2014) have enjoyed great success in a variety of tasks such as machine translation, speech recognition, and text summarization.

This model will give TF 2.0 end users a full understanding of seq2seq models and show them how to build a competitive seq2seq model from scratch. We focus on the task of Neural Machine Translation (NMT), which was the very first testbed for seq2seq models.

For the TensorFlow 1.x equivalent, please refer here.

The purpose of this issue is to migrate models into the TF 2.0 Keras API. Each migrated model must be eager and distribution compatible, with tests, and all associated engineering artifacts.

@dynamicwebpaige dynamicwebpaige added type:feature Feature requests TF 2.0 Issues relating to TensorFlow 2.0 labels Feb 1, 2019
@JACKHAHA363
Copy link

Any updates? I find that the keras high level API is not flexible enough compared to the old contrib.seq2seq.

@jvishnuvardhan jvishnuvardhan added comp:model Model related issues comp:tpus tpu, tpuestimator labels May 31, 2019
@npuichigo
Copy link

Any updates? +1

@jhseu jhseu assigned rachellj218 and unassigned jhseu Aug 19, 2019
@rachellj218
Copy link
Member

We are revamping the official model garden: more details can be viewed in this RFC tensorflow/community#130. We focus on supporting BERT and its variants for NLP tasks this quarter. We'd like to have NMT but don't have cycles now. Will try it include it in Q4.

@goldiegadde goldiegadde added TF 2.1 for tracking issues in 2.1 release and removed TF 2.0 Issues relating to TensorFlow 2.0 labels Oct 9, 2019
@gadagashwini gadagashwini self-assigned this Jun 3, 2022
@gadagashwini
Copy link
Contributor

Tensorflow v2.x supports Sequence-to-Sequence NMT with Attention Mechanism, for more information refer these links ref1 and ref2. Thank you!

@gadagashwini gadagashwini removed their assignment Jun 6, 2022
@mohantym mohantym self-assigned this Jan 14, 2023
@mohantym
Copy link
Contributor

Hi @dynamicwebpaige !
We are checking to see whether you still need help in this issue .

I think above add on documentation are still not compatible with tpu /dist-strat/eager mode.

Tested with nmt_with_attention from Tensorflow/text.
Results are not convincing in 2.9 too.

Attached gist for reference.

Thank you!

@mohantym mohantym added TF 2.9 Issues found in the TF 2.9 release (or RCs) comp:dist-strat Distribution Strategy related issues and removed TF 2.1 for tracking issues in 2.1 release comp:model Model related issues labels Jan 25, 2023
@mohantym mohantym removed their assignment Jan 25, 2023
@tilakrayal
Copy link
Contributor

Hi,

Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.

Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

@tilakrayal tilakrayal added the stat:awaiting response Status - Awaiting response from author label Jun 26, 2024
Copy link

github-actions bot commented Jul 4, 2024

This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jul 4, 2024
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:dist-strat Distribution Strategy related issues comp:tpus tpu, tpuestimator stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author TF 2.9 Issues found in the TF 2.9 release (or RCs) type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

10 participants