Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF 2.0 API Docs] tf.lite.TFLiteConverter #25844

Closed
margaretmz opened this issue Feb 18, 2019 · 2 comments
Closed

[TF 2.0 API Docs] tf.lite.TFLiteConverter #25844

margaretmz opened this issue Feb 18, 2019 · 2 comments
Assignees
@dynamicwebpaige
Labels
good first issue Good first issue for newcomers. stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.0 Issues relating to TensorFlow 2.0 type:docs-bug Document issues
Projects
TensorFlow 2.0

Comments

@margaretmz
Copy link
Contributor

margaretmz commented Feb 18, 2019 •
edited

System information

Describe the documentation issue

  • Links (Fixed)

Incorrect - https://github.com/tensorflow/tensorflow/blob/master/lite/python/lite.py
Correct - https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/python/lite.py

This is used to convert from a TensorFlow "GraphDef or SavedModel" into either a TFLite FlatBuffer or graph visualization.

Should be "…GraphDef, Saved Model or tf.keras model…"

This line of code should be repeated for each of the methods
open("converted_model.tflite", "wb").write(tflite_model)

  • Parameters Defined (Fixed)

Missing 2 parameters

  • optimizations
  • representative_dataset

We welcome contributions by users. Will you be able to update submit a PR (use the doc style guide) to fix the doc Issue?

Yes
@dynamicwebpaige dynamicwebpaige added type:docs-bug Document issues TF 2.0 Issues relating to TensorFlow 2.0 labels Feb 18, 2019
@jvishnuvardhan jvishnuvardhan added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Feb 20, 2019
@margaretmz margaretmz mentioned this issue Feb 24, 2019
Merged
margaretmz added a commit to margaretmz/tensorflow that referenced this issue Feb 24, 2019
@margaretmz
Updates description & example usage
39d1b3c 
Made changes per issue tensorflow#25844:
- Updated description to mention tf.Keras model. 
- Added the missing line in the example usage for SavedModel and tf.keras model.
@Ayush517
Copy link
Contributor

Ayush517 commented Mar 2, 2019

Is this issue still unsolved? The PR seems to have solved it but it isn't still merged? Does that mean something is still left?

@margaretmz
Copy link
Contributor Author

margaretmz commented Mar 3, 2019 •
edited

I'm waiting for PR #26067 to merge.

@dynamicwebpaige dynamicwebpaige added the good first issue Good first issue for newcomers. label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dynamicwebpaige dynamicwebpaige

Labels
good first issue Good first issue for newcomers. stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.0 Issues relating to TensorFlow 2.0 type:docs-bug Document issues
Projects
TensorFlow 2.0
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MarkDaoust @margaretmz @dynamicwebpaige @Ayush517 @jvishnuvardhan