Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for create_local_cluster #27567

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Update docs for create_local_cluster #27567

merged 4 commits into from
Apr 8, 2019

Conversation

lc0
Copy link
Contributor

@lc0 lc0 commented Apr 6, 2019 •
edited

WRONG

  • currently docs links to tf.train.Server that does not exist anymore

TODO:

  • add image in a proper way
  • fix a link to architecture page

cc @dynamicwebpaige

@lc0 lc0 changed the title Add definition of what PS stands for Update docs for create_local_cluster Apr 6, 2019
dynamicwebpaige
dynamicwebpaige previously approved these changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@dynamicwebpaige dynamicwebpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this, and for updating it to TensorFlow 2.0! 🙂 🎉

@rthadur rthadur self-assigned this Apr 7, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 7, 2019
@rthadur rthadur added size:S CL Change Size: Small kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 7, 2019
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 7, 2019
@lc0
Copy link
Contributor Author

lc0 commented Apr 7, 2019

I've added image as a markdown image, not sure if it's the best way. Since I've seen in some other part of the docs also img with some styles

@tensorflow-copybara tensorflow-copybara merged commit c4d4d60 into tensorflow:master Apr 8, 2019
PR Queue automation moved this from Reviewer Requested Changes to Merged Apr 8, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 8, 2019
@tensorflower-gardener
Merge pull request #27567 from lc0:muc-docs-sprint-2
c153c3f 
PiperOrigin-RevId: 242526744
@lc0
Copy link
Contributor Author

lc0 commented Apr 8, 2019

@dynamicwebpaige what do we do with non-existing tf.train.Server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamicwebpaige dynamicwebpaige Awaiting requested review from dynamicwebpaige

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lc0 @dynamicwebpaige @googlebot @kokoro-team @tensorflow-copybara @rthadur