[ROCm] Fix for the broken --config=rocm build.
#28263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This ia a different PR from tensorflow#28189 (same symptom, different cause and fix) The `--config=rocm` build was broken by the following commit. tensorflow@9b1b3df The changes made by the above commit were missing a couple of changes for the ROCm platform, whias was leading to the build failure. Adding those changes to make the `--config=rocm` build working again.
whchung
approved these changes
Apr 29, 2019
tensorflow-bot
bot
added
kokoro:force-run
timshen91
approved these changes
Apr 29, 2019
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 30, 2019
…ocm_platform_fix_190429 PiperOrigin-RevId: 245858649
deven-amd
added a commit
to ROCm/tensorflow-upstream
that referenced
this pull request
Apr 30, 2019
Note: This ia a different PR from PRs tensorflow#28189 and tensorflow#28263 (same symptom, different cause and fix) The `--config=rocm` build was broken by the following commit. tensorflow@481748b The changes made by the above commit had one bug in the changes for the ROCm platform, whias was leading to the build failure. Fixing that bug to make the `--config=rocm` build working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This ia a different PR from #28189 (same symptom, different cause and fix)
The
--config=rocmbuild was broken by the following commit.9b1b3df
The changes made by the above commit were missing a couple of changes for the ROCm platform, whias was leading to the build failure. Adding those changes to make the
--config=rocmbuild working again.@tatianashp , @whchung just FYI
Please approve and merge. As with PR #28189, the changes here are trivial and only applicable for the --config=rocm build.
thanks