Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual TF package breaks tf.sysconfig based include path #29532

Closed
byronyi opened this issue Jun 7, 2019 · 2 comments
Closed

Virtual TF package breaks tf.sysconfig based include path #29532

byronyi opened this issue Jun 7, 2019 · 2 comments
Assignees
@mihaimaruseac

Comments

@byronyi
Copy link
Contributor

byronyi commented Jun 7, 2019

As f1ffa02 landed yesterday, the framework library is now moved from tensorflow to tensorflow_core and the include path also changed to tensorflow_core/include.

tf.sysconfig.get_include and tf.sysconfig.get_lib should be changed accordingly but they are not. This breaks downstream packages such as horovod and tensorflow_io that build custom ops and link to TF. It also means any binary distributions of these packages will break binary backward compatibility with this change.

See horovod/horovod#1129 for a reproducing procedure.

Ping @mihaimaruseac @yifeif
byronyi pushed a commit to bytedance/tensorflow that referenced this issue Jun 7, 2019
sysconfig: Fix incorrect sysconfig.get_include and sysconfig.get_lib
d871511 
As tensorflow is a virtual Python package now, the corresponding path
should be under tensorflow_core.

This fixes tensorflow#29532.

Signed-off-by: Bairen Yi <yibairen.byron@bytedance.com>
byronyi pushed a commit to bytedance/tensorflow that referenced this issue Jun 7, 2019
sysconfig: Fix incorrect sysconfig.get_include and sysconfig.get_lib
5d68106 
As tensorflow is a virtual Python package now, the corresponding path
should be under tensorflow_core.

This fixes tensorflow#29532.

Signed-off-by: Bairen Yi <yibairen.byron@bytedance.com>
@seanpmorgan seanpmorgan mentioned this issue Jun 7, 2019
Closed
@mihaimaruseac mihaimaruseac self-assigned this Jun 7, 2019
@mihaimaruseac
Copy link
Collaborator

Sorry about that, will fix today.

@mihaimaruseac
Copy link
Collaborator

I think this should be fixed now, but let me know if not and I missed something.

sleighsoft pushed a commit to sleighsoft/tensorflow that referenced this issue Jun 12, 2019
@mihaimaruseac @sleighsoft
Fix include and lib path from virtual pip. Fix tensorflow#29532
0dc9859 
When making the virtual pip changes, by moving code to new directory, required headers and shared object are no longer vizible where they should. This should fix that.

PiperOrigin-RevId: 252100366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaimaruseac mihaimaruseac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihaimaruseac @byronyi