Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong includes for tensorflow-lite for ios #31506

Merged

Conversation

lukasfolle
Copy link
Contributor

I was trying to build the ios examples for tensorflow lite, however several include statements seemed to be wrong. This PR is fixing this.
Feel free to suggest any improvements.

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Aug 10, 2019
@lukasfolle
Copy link
Contributor Author

Also I found this issue #26924. This should fix it as well.

@rthadur rthadur self-assigned this Aug 12, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Aug 12, 2019
@rthadur rthadur requested a review from lamberta August 12, 2019 15:56
@lamberta lamberta requested review from jdduke and dansitu and removed request for lamberta August 12, 2019 16:28
@lamberta
Copy link
Member

I'm not sure of the status of these examples. Maybe they should move into the /lite section of the tensorflow/examples repo? @MarkDaoust @wolffg

@jdduke jdduke requested a review from miaout17 August 12, 2019 16:40
@rthadur rthadur added the comp:lite TF Lite related issues label Aug 12, 2019
@miaout17
Copy link
Contributor

Thanks for fixing these. It seems accidentally broken a while ago.

@lamberta Yes we plan to move most of the examples into tensorflow/examples, but it's not done yet. Meanwhile these changes look right. I'm going to approve this.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 14, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 14, 2019
@lukasfolle
Copy link
Contributor Author

@dansitu @jdduke Can this be merged?

tensorflow-copybara pushed a commit that referenced this pull request Aug 16, 2019
@tensorflow-copybara tensorflow-copybara merged commit 3edf8b1 into tensorflow:master Aug 16, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Aug 16, 2019
@lukasfolle lukasfolle deleted the lukas-tf-lite-ios-fix branch August 16, 2019 20:08
@yyoon yyoon mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants