[INTEL MKL]Fixing spurious omp thread spawning #32485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@penpornk This is the PR to fix openmp configuration. Please let me know of any changes. |
penpornk
requested changes
Sep 13, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
Thanks @penpornk. |
|
Hi @penpornk , is everything okay with the PR? |
|
@Srini511 Let's talk through email. :) |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Sep 13, 2019
…xplosion PiperOrigin-RevId: 268978189
This was referenced Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some models that use eager/imperative code where we don’t rewrite a few operators to MKL, a lot (intra_op_threads*OMP_NUM_THREADS) of threads are spawned by Eigen matmul code. This is because -fopenmp flag is passed to Eigen as part of the build configuration. This PR fixes the configuration to not pass -fopenmp to Eigen under --config=mkl.