Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2.0 CherryPick]: [INTEL MKL] Fixing spurious omp thread spawning #32514

Merged
merged 6 commits into from
Sep 14, 2019

Conversation

penpornk
Copy link
Member

This PR fixes the core over-utilization issue when Eigen and OpenMP threadings crash.

From PR #32485:
In some models that use eager/imperative code where we don’t rewrite a few operators to MKL, a lot (intra_op_threads*OMP_NUM_THREADS) of threads are spawned by Eigen matmul code. This is because -fopenmp flag is passed to Eigen as part of the build configuration. This PR fixes the configuration to not pass -fopenmp to Eigen under --config=mkl.

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Sep 14, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@penpornk penpornk added cla: yes kokoro:force-run Tests on submitted change and removed cla: no labels Sep 14, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 14, 2019
@penpornk
Copy link
Member Author

Manually setting CLA to yes because all the co-authored commits are from PR #32485 that is already merged in master.

@goldiegadde goldiegadde self-assigned this Sep 14, 2019
@gunan gunan merged commit 396daca into tensorflow:r2.0 Sep 14, 2019
@penpornk penpornk deleted the cherrypicks_ZN9NV branch October 3, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants