Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let us decide the index of the blank in tf.nn.ctc_greedy_decoder #32903

Closed
FLming opened this issue Sep 29, 2019 · 10 comments
Closed

Let us decide the index of the blank in tf.nn.ctc_greedy_decoder #32903

FLming opened this issue Sep 29, 2019 · 10 comments
Assignees
Labels
comp:apis Highlevel API related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:feature Feature requests

Comments

@FLming
Copy link

FLming commented Sep 29, 2019

System information

  • TensorFlow version (you are using): 2.0.0rc1
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.

I am using ctc_greedy_decoder function to decode my output from logits. In the ctc_loss function, we have the opportunity to choose blank_index equals what, but in the ctc_greedy_decoder function, it seems equals (num_classes-1) by default. Thus I have to write a map function by myself or change my lookup table

Will this change the current api? How?

Please add a parameter to this function in order to choose which index we use.

@gadagashwini-zz gadagashwini-zz self-assigned this Sep 30, 2019
@gadagashwini-zz gadagashwini-zz added TF 2.0-rc0 comp:apis Highlevel API related issues type:feature Feature requests labels Sep 30, 2019
@ymodak ymodak added comp:ops OPs related issues and removed comp:apis Highlevel API related issues labels Sep 30, 2019
@ymodak ymodak added comp:apis Highlevel API related issues and removed comp:ops OPs related issues labels Jan 10, 2020
@ymodak ymodak assigned ebrevdo and unassigned ymodak Jan 10, 2020
@ebrevdo ebrevdo added the stat:contribution welcome Status - Contributions welcome label Jan 12, 2020
@pvarouktsis
Copy link
Contributor

Hello! Is anyone working on this? If not could I have a try?

@ebrevdo
Copy link
Contributor

ebrevdo commented Apr 3, 2020 via email

@pvarouktsis
Copy link
Contributor

Thank you!

@FLming
Copy link
Author

FLming commented Apr 4, 2020

Although I really want to do this, I don’t know how to contribute it. I have gone to view the implementation of this function, but I can't find the gen_ctc_ops module. Maybe it implemented by c/c++ code, I am not clear how the python code calls the c/c++ code. There also have a function should add the parameter: tf.nn.ctc_beam_search_decoder.

@ebrevdo
Copy link
Contributor

ebrevdo commented Apr 4, 2020 via email

@lvenugopalan lvenugopalan added TF 2.0 Issues relating to TensorFlow 2.0 and removed TF 2.0-rc0 labels Apr 29, 2020
@tilakrayal
Copy link
Contributor

@FLming ,
Related PR was merged.Can you please let us confirm if the issue has resolved with the merged PR.

@tilakrayal tilakrayal self-assigned this Dec 18, 2021
@tilakrayal tilakrayal added stat:awaiting response Status - Awaiting response from author and removed stat:contribution welcome Status - Contributions welcome TF 2.0 Issues relating to TensorFlow 2.0 labels Dec 18, 2021
@google-ml-butler
Copy link

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.

@google-ml-butler google-ml-butler bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Dec 25, 2021
@FLming
Copy link
Author

FLming commented Dec 27, 2021

OK, I will check it in this week.

@google-ml-butler google-ml-butler bot removed the stale This label marks the issue/pr stale - to be closed automatically if no activity label Dec 27, 2021
@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Dec 27, 2021
@tilakrayal tilakrayal added the stat:awaiting response Status - Awaiting response from author label Dec 27, 2021
@google-ml-butler
Copy link

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.

@google-ml-butler google-ml-butler bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jan 3, 2022
@FLming
Copy link
Author

FLming commented Jan 4, 2022

LGFM. Thanks.

@FLming FLming closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:apis Highlevel API related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

7 participants