Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKL DNN 1.0 integration - refactoring MKL conv forward op #35908

Closed
wants to merge 1 commit into from

Conversation

nammbash
Copy link
Contributor

This PR is intended to refactor the current implementation of forward conv ops with MKL-DNN
v1.0 integration:
(1) Abstract macro definitions from individual source files to a common header file (mkl_types)
for better code reuse (in coming PR's)
(2) Refactor based on Google coding style. For instance, replace CHECK_NOTNULL to DCHECK.

Background:
We (Intel) will submit a sequence of PR's with MKL-DNN v1.0 integration (around 24 MKL ops).
And this PR will be fundamental for the near future PR's.

Reference of previously merged PR:
#30549

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Jan 15, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no size:L CL Change Size: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants