Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm][XLA] Adding three passes to amdgpu compiler #36191

Merged
merged 1 commit into from Feb 10, 2020
Merged

[ROCm][XLA] Adding three passes to amdgpu compiler #36191

merged 1 commit into from Feb 10, 2020

Conversation

jerryyin
Copy link
Member

This CL (comes from discussions in #35991) introduced three passes to keep amdgpu_compiler in sync with nvptx_compiler:

  • reduction_degernerate_dim_remover
  • reduction_dimension_grouper
  • reduction_layout_normalizer

@whchung @cheshire

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jan 24, 2020
@jerryyin jerryyin mentioned this pull request Jan 24, 2020
Merged
@whchung whchung added the kokoro:force-run Tests on submitted change label Jan 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 24, 2020
@rthadur rthadur self-assigned this Jan 24, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jan 24, 2020
@rthadur rthadur added the comp:gpu GPU related issues label Jan 24, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jan 29, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 29, 2020
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 5, 2020
@jerryyin
Copy link
Member Author

@cheshire Is it causing some internal failures? I don't have visibility in the import/copybara tab.

@cheshire
Copy link
Member

That's strange, let me try again.

@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Feb 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 10, 2020
tensorflow-copybara pushed a commit that referenced this pull request Feb 10, 2020
@tensorflower-gardener
Merge pull request #36191 from ROCmSoftwarePlatform:google-upstream-p…
cf35e65 
…r-enable-passes-amdgpu_compiler

PiperOrigin-RevId: 294239845
Change-Id: I905c62570b73021a8275dd2925d5badb0af1ceee
@tensorflow-copybara tensorflow-copybara merged commit 9d3d2d3 into tensorflow:master Feb 10, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheshire cheshire cheshire approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jerryyin @cheshire @whchung @googlebot @kokoro-team @tensorflow-copybara @rthadur