Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm][XLA] Enabling llvm compiler test #35991

Merged
merged 2 commits into from Feb 4, 2020
Merged

[ROCm][XLA] Enabling llvm compiler test #35991

merged 2 commits into from Feb 4, 2020

Conversation

jerryyin
Copy link
Member

@jerryyin jerryyin commented Jan 17, 2020 •
edited

This CL enabled the llvm_compiler_test to test the dummy implementation of GpuCompiler.

@whchung @cheshire

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jan 17, 2020
cheshire
cheshire requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cheshire cheshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make those switches at runtime instead of compile time? Also if the code is shared between nvptx_compiler and amdgpu_compiler, could it be thrown in gpu_compiler instead?

@rthadur rthadur self-assigned this Jan 18, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jan 18, 2020
@rthadur rthadur added the comp:xla XLA label Jan 18, 2020
@jerryyin jerryyin force-pushed the google-upstream-pr-sync-amdgpu_compiler branch from 29e53b1 to 8a1f448 Compare January 21, 2020 19:36
@rthadur
Copy link
Contributor

rthadur commented Jan 22, 2020

@cheshire gentle ping to review new changes , thank you

@rthadur rthadur added the kokoro:force-run Tests on submitted change label Jan 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 23, 2020
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 24, 2020
@jerryyin jerryyin force-pushed the google-upstream-pr-sync-amdgpu_compiler branch from 8a1f448 to b27daf6 Compare January 24, 2020 21:40
@jerryyin jerryyin changed the title [ROCm][XLA] Updating amdgpu compiler and enabling llvm compiler test [ROCm][XLA] Enabling llvm compiler test Jan 24, 2020
@jerryyin jerryyin mentioned this pull request Jan 24, 2020
Merged
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 29, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 29, 2020
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jan 29, 2020
tensorflow-copybara pushed a commit that referenced this pull request Feb 4, 2020
@tensorflower-gardener
Merge pull request #35991 from ROCmSoftwarePlatform:google-upstream-p…
6627cec 
…r-sync-amdgpu_compiler

PiperOrigin-RevId: 293101075
Change-Id: I669f4faddc2c9712cbb58a74a4b0f45d0ee9e471
@tensorflow-copybara tensorflow-copybara merged commit b27daf6 into tensorflow:master Feb 4, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Feb 4, 2020
@jerryyin jerryyin mentioned this pull request Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheshire cheshire cheshire approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jerryyin @rthadur @cheshire @googlebot @kokoro-team @tensorflow-copybara