Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expired forward compatibility horizons #37801

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Remove expired forward compatibility horizons #37801

merged 1 commit into from
Mar 24, 2020

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Mar 22, 2020

This PR removes expired forward compatibility statements that always evaluate to True.

@lgeiger
Remove expired forward compatibility horizons
503f341 
This PR removes expired forward compatibility statements that will always evaluate to `True`.
@tensorflow-bot tensorflow-bot bot added the size:M CL Change Size: Medium label Mar 22, 2020
@gbaned gbaned self-assigned this Mar 23, 2020
@gbaned gbaned requested a review from frankchn March 23, 2020 05:12
lgeiger
lgeiger commented Mar 23, 2020
View reviewed changes
Copy link
Contributor Author

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankchn Thanks for the review. I made some comments to try and explain my reasoning.

tensorflow/compiler/tests/einsum_op_test.py Show resolved Hide resolved
tensorflow/python/data/experimental/ops/distribute.py Show resolved Hide resolved
tensorflow/python/data/ops/dataset_ops.py Show resolved Hide resolved
@lgeiger lgeiger requested a review from frankchn March 23, 2020 16:49
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 24, 2020
@tensorflow-copybara tensorflow-copybara merged commit 2f3651d into tensorflow:master Mar 24, 2020
@lgeiger lgeiger deleted the cleanup-fwd-compat branch March 24, 2020 18:40
@lgeiger lgeiger mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankchn frankchn frankchn approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgeiger @frankchn @googlebot @kokoro-team @tensorflow-copybara @gbaned