Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API to provide custom table level optimizers in TPUEmbedding. #39295

Merged
merged 1 commit into from
May 10, 2020
Merged

API to provide custom table level optimizers in TPUEmbedding. #39295

merged 1 commit into from
May 10, 2020

Conversation

gagika
Copy link

@gagika gagika commented May 8, 2020

PiperOrigin-RevId: 309314962
Change-Id: I064af4b62b84a5eadc2e1e7f4cfb875812252549

@tensorflower-gardener @gagika
API to provide custom table level optimizers in TPUEmbedding.
1900982 
PiperOrigin-RevId: 309314962
Change-Id: I064af4b62b84a5eadc2e1e7f4cfb875812252549
bfontain
bfontain approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@bfontain bfontain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 8, 2020
@mihaimaruseac mihaimaruseac self-assigned this May 8, 2020
@mihaimaruseac mihaimaruseac added the waiting for patch release PR will be reviewed and merged only if we do a patch release since PR is not on master branch label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 8, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 8, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 8, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 9, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 9, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 10, 2020
@mihaimaruseac mihaimaruseac merged commit c98386b into tensorflow:r1.15 May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauheen shauheen shauheen approved these changes

@bfontain bfontain bfontain approved these changes

Assignees

@mihaimaruseac mihaimaruseac

Labels
cla: yes waiting for patch release PR will be reviewed and merged only if we do a patch release since PR is not on master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gagika @shauheen @bfontain @mihaimaruseac @googlebot @kokoro-team @tensorflower-gardener