Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blank_index parameter for ctc_greedy_decoder #39324

Merged
merged 29 commits into from May 13, 2021
Merged

Add blank_index parameter for ctc_greedy_decoder #39324

merged 29 commits into from May 13, 2021

Conversation

pvarouktsis
Copy link
Contributor

@pvarouktsis pvarouktsis commented May 8, 2020 •
edited

This PR resolves issue #32903.

Added an extra parameter in ctc_greedy_decoder to be able to specify the blank index. Also updated test cases and documentation.

@pvarouktsis
Update ctc_greedy_decoder in tensorflow.nn.pbtxt
aa0a19a 
Add blank_index as parameter with default value None
@pvarouktsis
Add blank_index parameter at ctc_greedy_decoder in ctc_ops
9526a2f 
If blank_index is None then num_classes - 1
@pvarouktsis
Add blank_index as parameter in ctc_greedy_decoder v1
9d6b04c
@pvarouktsis
Update wrong Documentation in ctc_loss_op_test
f58a547
@pvarouktsis
Implement blank_index parameter in ctc_greedy_decoder
9e04473 
Added blank_index as parameter in ctc_greedy_decoder
Only accepting positive number
@pvarouktsis
Implement test case for blank_index in ctc_greedy_decoder
aa2be96
@pvarouktsis
Implement blank_index accepting negative values
be365ea
@pvarouktsis
Update Docs and implement test for negative blank_index
8767a81
@pvarouktsis
Update Docs in ctc_greedy_decoder at ctc_ops
14f191d
@pvarouktsis
Edit if conditions for blank_index to reduce unnecessary processes
81fece5
@pvarouktsis
Fix coding style in ctc_ops
fd07fbe
@pvarouktsis
Update test case for ctc_greedy_decoder
27e92c8 
Staffed all test cases in testCTCGreedyDecoder
@pvarouktsis
Implement blank_index for ctc_greedy_decoder
ff2f6bb 
Added a parameter in ctc_greedy_decoder to specify
the index of blank symbol.
Updated test cases in ctc_decoder_ops_test
Updated Docs
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label May 8, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pvarouktsis
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2020
@pvarouktsis pvarouktsis changed the title Implement blank_index for ctc_greedy_decoder #32903 Implement blank_index for ctc_greedy_decoder May 8, 2020
@pvarouktsis pvarouktsis changed the title Implement blank_index for ctc_greedy_decoder Add blank_index parameter for ctc_greedy_decoder May 9, 2020
@gbaned gbaned self-assigned this May 11, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 11, 2020
@gbaned gbaned requested a review from sanjoy May 11, 2020 04:11
@sanjoy sanjoy requested a review from reedwm May 12, 2020 12:37
@gbaned gbaned added the awaiting review Pull request awaiting review label May 15, 2020
@reedwm reedwm removed the request for review from sanjoy May 19, 2020 18:07
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Mar 16, 2021
@tensorflowbutler
Copy link
Member

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

PR Queue automation moved this from Reviewer Requested Changes to Closed/Rejected Mar 17, 2021
@pvarouktsis pvarouktsis reopened this Mar 17, 2021
PR Queue automation moved this from Closed/Rejected to Assigned Reviewer Mar 17, 2021
@pvarouktsis
Copy link
Contributor Author

Yes, I'm still valid.

@google-ml-butler google-ml-butler bot removed the stale This label marks the issue/pr stale - to be closed automatically if no activity label Mar 17, 2021
@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Mar 19, 2021
@gbaned gbaned requested a review from ebrevdo April 6, 2021 17:25
@gbaned gbaned added the awaiting review Pull request awaiting review label Apr 6, 2021
@gbaned
Copy link
Contributor

gbaned commented Apr 21, 2021

@ebrevdo Can you please review this PR ? Thanks!

@gbaned gbaned requested a review from allenlavoie April 30, 2021 14:26
allenlavoie
allenlavoie approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@allenlavoie allenlavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except for the pyext.cpp_message->internal.python_message API golden changes. I assume you'll need to revert those files to get the sanity tests to pass. This will also need an API review.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 30, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label May 5, 2021
@pvarouktsis
Copy link
Contributor Author

Thank you very much!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 5, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label May 6, 2021
@copybara-service copybara-service bot merged commit 053a191 into tensorflow:master May 13, 2021
PR Queue automation moved this from Assigned Reviewer to Merged May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenlavoie allenlavoie allenlavoie approved these changes

@karmel karmel Awaiting requested review from karmel

@ebrevdo ebrevdo Awaiting requested review from ebrevdo

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pvarouktsis @googlebot @gbaned @ebrevdo @rthadur @tensorflowbutler @karmel @allenlavoie @kokoro-team