Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct scatter file values for STM32F4 target #44015

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

freddan80
Copy link
Contributor

The emulated target platform has more SRAM and flash than what is currently stated in the scatter file.

Fixes #43743

Change-Id: Iee3b278d7cfa98b348d0d908bf62a21fcdcf1ace
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Oct 14, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
Change-Id: I4c57b84a3ea735360a4bde89a906401121dbad0b
@freddan80
Copy link
Contributor Author

@advaitjain this should make it possible to run:
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=stm32f4 TAGS=cmsis-nn person_detection_benchmark

@gbaned gbaned self-assigned this Oct 14, 2020
@gbaned gbaned added comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers prtype:bugfix PR to fix a bug labels Oct 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 14, 2020
@copybara-service copybara-service bot merged commit 0b87019 into tensorflow:master Oct 15, 2020
@freddan80 freddan80 deleted the pr_1014_scatter branch October 29, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

person_detection benchmarks do not build for STM32F4
4 participants