Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Intel MKL] Enabling Quantized Conv ops in native format mode #45108

Merged
merged 5 commits into from May 22, 2021
Merged

[Intel MKL] Enabling Quantized Conv ops in native format mode #45108

merged 5 commits into from May 22, 2021

Conversation

mahmoud-abuzaina
Copy link
Contributor

@mahmoud-abuzaina mahmoud-abuzaina commented Nov 23, 2020 •
edited

No description provided.

@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@gbaned gbaned self-assigned this Nov 24, 2020
@gbaned gbaned added the comp:mkl MKL related issues label Nov 24, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 24, 2020
@gbaned gbaned requested a review from penpornk November 24, 2020 06:29
@gbaned gbaned added the awaiting review Pull request awaiting review label Nov 25, 2020
penpornk
penpornk requested changes Dec 29, 2020
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and I'm so sorry for the delay!

tensorflow/core/kernels/mkl/mkl_conv_ops.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_conv_ops.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_conv_ops.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_test.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_test.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_perchannel_test.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_test.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_test.cc Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Dec 29, 2020
@penpornk penpornk removed the awaiting review Pull request awaiting review label Dec 29, 2020
@penpornk penpornk mentioned this pull request Dec 30, 2020
Merged
@mahmoud-abuzaina
Copy link
Contributor Author

Thank you for the valuable comments. I have addressed them.

penpornk
penpornk requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and for cleaning up the registrations even further! I have a few nits.

tensorflow/core/kernels/mkl/mkl_kernel_util.h Outdated
#include "tensorflow/core/kernels/quantization_utils.h"

namespace tensorflow {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please remove this blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tensorflow/core/kernels/mkl/mkl_kernel_util.h Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_quantized_conv_ops_test.cc Outdated Show resolved Hide resolved
tensorflow/core/kernels/mkl/mkl_kernel_util.h Outdated Show resolved Hide resolved
@mahmoud-abuzaina
Copy link
Contributor Author

I have addressed the remaining comments. Please have a look. Thank you!

@mahmoud-abuzaina mahmoud-abuzaina mentioned this pull request Jan 5, 2021
Merged
@gbaned gbaned requested a review from penpornk January 6, 2021 13:51
penpornk
penpornk approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! This PR looks good to me now. I think I can just approve it and remove the ready-to-pull tag. (Will add it back after #45107 is merged.)

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 7, 2021
@gbaned gbaned added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Feb 5, 2021
@gbaned gbaned requested a review from penpornk February 15, 2021 14:34
@gbaned gbaned requested review from penpornk and removed request for penpornk March 17, 2021 19:03
penpornk
penpornk approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and I'm sorry for the delay!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 21, 2021
@gbaned gbaned removed stat:awaiting tensorflower Status - Awaiting response from tensorflower ready to pull PR ready for merge process labels May 21, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 21, 2021
@copybara-service copybara-service bot merged commit 277b473 into tensorflow:master May 22, 2021
PR Queue automation moved this from Approved by Reviewer to Merged May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahmoud-abuzaina @penpornk @gbaned @kokoro-team