[Intel MKL] Enabling quantized pooling ops with native format #45484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
requested changes
Dec 30, 2020
| Tensor output_quantized; | ||
| conv_comp.ConvertMKL2TF<quint8>(DT_QUINT8, output, mkl_shape_tensor, | ||
| output_quantized); | ||
| if (!NativeFormatEnabled()) { |
There was a problem hiding this comment.
This part can use the refactored function mentioned in #45108.
There was a problem hiding this comment.
I used the refactored function form #45108.
|
Thank you for the comments. I addressed them. |
penpornk
requested changes
Jan 5, 2021
| NativeFormatEnabled() ? output : output_quantized, output_min, | ||
| output_max); | ||
|
|
||
| const Tensor* mkl_shape_tensor = |
There was a problem hiding this comment.
Nit: Can we add _ptr to the name? Same for line 180.
Suggested change
| const Tensor* mkl_shape_tensor = | |
| const Tensor* mkl_shape_tensor_ptr = |
There was a problem hiding this comment.
Sure. Done.
|
I have addressed the comment. Thank you! |
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
the
stat:awaiting tensorflower
penpornk
approved these changes
May 20, 2021
gbaned
removed
ready to pull
gbaned
approved these changes
May 21, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.