Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel can't fetch numeric-1.2.6.min.js because numericjs.com has expired #4583

Closed
sharkdtu opened this issue Sep 26, 2016 · 4 comments
Closed

Bazel can't fetch numeric-1.2.6.min.js because numericjs.com has expired #4583

sharkdtu opened this issue Sep 26, 2016 · 4 comments
Assignees
@jart

Comments

@sharkdtu
Copy link
Contributor

sharkdtu commented Sep 26, 2016 •
edited

INFO: Downloading from http://www.numericjs.com/lib/numeric-1.2.6.min.js: 0B

When i opened it on my broswer, it prompted that numericjs.com has expired
@natlachaman
Copy link

same problem here

@jart jart self-assigned this Sep 26, 2016
@jart
Copy link
Contributor

jart commented Sep 26, 2016

Hey @dsmilkov where can we download this from GitHub? I found https://github.com/sloisel/numeric/blob/master/src/numeric.js but it doesn't appear to be the same code that we have checked in internally, even though the versions are the same.

Or better yet, is there another library we could use?

cc: @danmane

@dsmilkov
Copy link
Contributor

https://github.com/sloisel/numeric/blob/master/src/numeric.js is just a portion of the library (uncompiled), and the author doesn't store the compiled/bundled one on github.

We can link to:
https://cdnjs.cloudflare.com/ajax/libs/numeric/1.2.6/numeric.min.js

Cloudfare CDN should be pretty stable. Let me know your thoughts

@dsmilkov
Copy link
Contributor

dsmilkov commented Sep 26, 2016 •
edited

Submitted an internal change where numericjs gets pulled from cloudflare cdn. The internal change should show up in github within a day.

Thanks @sharkdtu and @natlachaman for bringing this issue to our attention!

bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Nov 29, 2016
@jart @kchodorow
Support multiple mirror URLs for external repos
ed7ced0 
This change improves upon 4c67807.

- A urls attribute has been added to the native workspace rules, with
  the exception of maven_jar and git_repository. The Skylark repository
  API also supports multiple URLs now.

- The earlier mirrors in the list are preferred. Failover will happen
  automatically in parallel.

- The first 32kB of data is checked before choosing a mirror in order
  to evade captive portals.

- If one's Internet goes down or a download times out, then the
  download will resume automatically where it left off, provided the
  server supports RFC7233 for that particular file. Please note that
  GitHub does not support this for archive snapshots. Files should
  always be mirrored to a CDN, e.g. GCS, because they support this.

- A semaphore is now used on downloads so only 8 can happen at once.

Fixes #1814
Fixes #2131
Fixes #2008
Fixes #1968
Fixes #1717
Fixes #943
Wont fix #1194
Fixes tensorflow/tensorflow#5933
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5432
See #1607
See #821
See tensorflow/tensorflow#5080
See tensorflow/tensorflow#5029
See tensorflow/tensorflow#4583
See tensorflow/tensorflow#4058

RELNOTES: A urls attribute has been added to repository rules to support multiple mirror URLs for reliably downloading files.

--
MOS_MIGRATED_REVID=140495736
laszlocsomor pushed a commit to bazelbuild/bazel that referenced this issue Nov 30, 2016
@jart @laszlocsomor
Support multiple mirror URLs for external repos
92887a0 
This change improves upon 4c67807.

- A urls attribute has been added to the native workspace rules, with
  the exception of maven_jar and git_repository. The Skylark repository
  API also supports multiple URLs now.

- The earlier mirrors in the list are preferred. Failover will happen
  automatically in parallel.

- The first 32kB of data is checked before choosing a mirror in order
  to evade captive portals.

- If one's Internet goes down or a download times out, then the
  download will resume automatically where it left off, provided the
  server supports RFC7233 for that particular file. Please note that
  GitHub does not support this for archive snapshots. Files should
  always be mirrored to a CDN, e.g. GCS, because they support this.

- A semaphore is now used on downloads so only 8 can happen at once.

Fixes #1814
Fixes #2131
Fixes #2008
Fixes #1968
Fixes #1717
Fixes #943
Wont fix #1194
Fixes tensorflow/tensorflow#5933
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5432
See #1607
See #821
See tensorflow/tensorflow#5080
See tensorflow/tensorflow#5029
See tensorflow/tensorflow#4583
See tensorflow/tensorflow#4058

RELNOTES: A urls attribute has been added to repository rules to support multiple mirror URLs for reliably downloading files.

--
MOS_MIGRATED_REVID=140495736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jart jart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jart @dsmilkov @sharkdtu @natlachaman