Fix crash of tf.strings.substr when pos and len have different shapes #46974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to address the issue raised in 46900 where tf.strings.substr will crash when pos and len have different shapes. According to the documentation of tf.strings.substr, ValueError should be raised instead when pos and len does not have the same shape. This PR add shape check in kernel to allows grace error throw (instead of crash). This PR fixes 46900. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
mihaimaruseac
approved these changes
Feb 8, 2021
google-ml-butler
bot
added
kokoro:force-run
geetachavan1
added a commit
to geetachavan1/tensorflow
that referenced
this pull request
May 19, 2021
…en pos and len have different shapes
geetachavan1
added a commit
to geetachavan1/tensorflow
that referenced
this pull request
May 19, 2021
…en pos and len have different shapes
geetachavan1
added a commit
to geetachavan1/tensorflow
that referenced
this pull request
May 19, 2021
…en pos and len have different shapes
geetachavan1
added a commit
to geetachavan1/tensorflow
that referenced
this pull request
May 19, 2021
…en pos and len have different shapes
mihaimaruseac
added a commit
that referenced
this pull request
May 19, 2021
CherryPick:2.1:PR #46974: Fix crash of tf.strings.substr when pos and len have different shapes
mihaimaruseac
added a commit
that referenced
this pull request
May 19, 2021
CherryPick:2.2:PR #46974: Fix crash of tf.strings.substr when pos and len have different shapes
mihaimaruseac
added a commit
that referenced
this pull request
May 19, 2021
CherryPick:2.3:PR #46974: Fix crash of tf.strings.substr when pos and len have different shapes
mihaimaruseac
added a commit
that referenced
this pull request
May 19, 2021
CherryPick:2.4:PR #46974: Fix crash of tf.strings.substr when pos and len have different shapes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue raised in #46900 where
tf.strings.substr will crash when pos and len have different shapes.
According to the documentation of tf.strings.substr, ValueError
should be raised instead when pos and len does not have the same shape.
This PR add shape check in kernel to allows grace error throw (instead of crash).
This PR fixes #46900.
Signed-off-by: Yong Tang yong.tang.github@outlook.com