Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash of tf.strings.substr when pos and len have different shapes #46974

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix crash of tf.strings.substr when pos and len have different shapes #46974

merged 1 commit into from
Feb 9, 2021

Commits on Feb 6, 2021

  1. Fix crash of tf.strings.substr when pos and len have different shapes 

    This PR tries to address the issue raised in 46900 where
tf.strings.substr will crash when pos and len have different shapes.
According to the documentation of tf.strings.substr, ValueError
should be raised instead when pos and len does not have the same shape.

This PR add shape check in kernel to allows grace error throw (instead of crash).

This PR fixes 46900.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    7edb8c9 View commit details
    Browse the repository at this point in the history