Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault for multiframe gifs. #58104

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Fix segfault for multiframe gifs. #58104

merged 4 commits into from
Dec 28, 2022

Conversation

API92
Copy link
Contributor

@API92 API92 commented Oct 15, 2022 •
edited
Loading

Integer overflow occurs when 2^31 <= num_frames * height * width * channels < 2^32, for example Full HD screencast of at least 346 frames.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Oct 15, 2022
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Oct 17, 2022
@gbaned gbaned requested a review from hyeygit October 17, 2022 13:39
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 17, 2022
mihaimaruseac
mihaimaruseac requested changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptrdiff_t has a different semantic. You want an integer type, not a difference between 2 addresses

tensorflow/core/kernels/image/decode_image_op.cc Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 28, 2022
mihaimaruseac
mihaimaruseac requested changes Dec 28, 2022
View reviewed changes
tensorflow/core/kernels/image/decode_image_op.cc Outdated Show resolved Hide resolved
tensorflow/core/lib/gif/gif_io_test.cc Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 28, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 28, 2022
@mihaimaruseac mihaimaruseac removed the request for review from hyeygit December 28, 2022 17:30
@copybara-service copybara-service bot merged commit 3fafde4 into tensorflow:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@API92 @mihaimaruseac @kokoro-team @gbaned