Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractImagePatches gradient refactoring (XLA + speedup) #59185

Merged
merged 2 commits into from
Mar 30, 2023
Merged

ExtractImagePatches gradient refactoring (XLA + speedup) #59185

merged 2 commits into from
Mar 30, 2023

Conversation

shkarupa-alex
Copy link
Contributor

Fixes #59058 and #59061
Improves #20146

Colab + CPU:

Implementation CPU user CPU sys CPU total Wall time
Current 2.80 s 1.73 s 4.54 s 5.39 s
Proposed 2.87 s 42.20 ms 2.91 s 3.05 s

Colab + GPU

Implementation CPU user CPU sys CPU total Wall time
Current 907.0 ms 266.0 ms 1.17 s 830 ms
Proposed 17.4 ms 2.1 ms 19.50 ms 56.7 ms

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jan 9, 2023
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jan 9, 2023
@gbaned gbaned requested a review from reedwm January 10, 2023 12:47
@rohan100jain rohan100jain requested review from jsmeredith and removed request for rohan100jain January 10, 2023 14:10
@reedwm reedwm removed their request for review January 11, 2023 00:20
@shkarupa-alex shkarupa-alex mentioned this pull request Jan 16, 2023
Closed
@rohan100jain rohan100jain removed their request for review March 24, 2023 00:05
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 28, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 28, 2023
@copybara-service copybara-service bot merged commit e5e9f85 into tensorflow:master Mar 30, 2023
@shkarupa-alex shkarupa-alex deleted the patches_xla branch March 31, 2023 05:54
@shkarupa-alex shkarupa-alex mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmeredith jsmeredith jsmeredith approved these changes

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf.image.extract_patches fails to JIT-compile inside keras model
4 participants
@shkarupa-alex @jsmeredith @kokoro-team @gbaned