Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//tensorflow/python/kernel_tests/proto:decode_proto_op_test fails with protobuf > 3.20.3 #59930

Open
elfringham opened this issue Mar 8, 2023 · 5 comments
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues TF 2.11 Issues related to TF 2.11 type:build/install Build and install issues

Comments

@elfringham
Copy link
Contributor

elfringham commented Mar 8, 2023

Click to expand!

Issue Type

Bug

Have you reproduced the bug with TF nightly?

Yes

Source

source

Tensorflow Version

git HEAD

Custom Code

No

OS Platform and Distribution

Ubuntu 20.04

Mobile device

n/a

Python version

3.9.16

Bazel version

5.3.0

GCC/Compiler version

9.4.0

CUDA/cuDNN version

n/a

GPU model and memory

n/a

Current Behaviour?

The test fails

Standalone code to reproduce the issue

bazel test --test_timeout=300,500,-1,-1 --flaky_test_attempts=3 --test_output=all --cache_test_results=no --noremote_accept_cached --test_env=TF_ENABLE_ONEDNN_OPTS=1 --build_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-requires-gpu --test_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-requires-gpu --verbose_failures --build_tests_only --jobs=16 -- //tensorflow/python/kernel_tests/proto:decode_proto_op_test

Relevant log output

ERROR: testBinaryDisordereddefaults (__main__.DecodeProtoOpTest)
DecodeProtoOpTest.testBinaryDisordereddefaults
testBinaryDisordereddefaults(values {
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/proto/decode_proto_op_test.runfiles/absl_py/absl/testing/parameterized.py", line 316, in bound_param_test
    return test_method(self, *testcase_params)
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/proto/decode_proto_op_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/proto/decode_proto_op_test_base.py", line 223, in testBinaryDisordered
    self._runDecodeProtoTests(
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/proto/decode_proto_op_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/proto/decode_proto_op_test_base.py", line 206, in _runDecodeProtoTests
    self._compareProtos(batch_shape, sizes, fields, field_dict)
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/proto/decode_proto_op_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/proto/decode_proto_op_test_base.py", line 142, in _compareProtos
    self._compareValues(fd, values.flat,
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/kernel_tests/proto/decode_proto_op_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/proto/decode_proto_op_test_base.py", line 57, in _compareValues
    if fd.cpp_type == fd.CPPTYPE_FLOAT:
AttributeError: 'google._upb._message.FieldDescriptor' object has no attribute 'CPPTYPE_FLOAT'
@google-ml-butler google-ml-butler bot added the type:bug Bug label Mar 8, 2023
@gaikwadrahul8 gaikwadrahul8 added subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues type:build/install Build and install issues TF 2.11 Issues related to TF 2.11 and removed type:bug Bug labels Mar 8, 2023
@gaikwadrahul8
Copy link
Contributor

Hi, @SuryanarayanaY

Could you please look into this issue ? Thank you!

@SuryanarayanaY
Copy link
Collaborator

@elfringham ,

I have replicated the reported test failure and got the same error reported by you.

AttributeError: 'google._upb._message.FieldDescriptor' object has no attribute 'CPPTYPE_FLOAT'

Please refer to attached log below and acknowledge.Please note that I used the same bazel environment that used for #59931, in which ticket also reported error replicated.

59930_logs.txt

@elfringham
Copy link
Contributor Author

@SuryanarayanaY Yes, that matches the failure I see.

@SuryanarayanaY
Copy link
Collaborator

CC - @learning-to-play

@learning-to-play
Copy link
Collaborator

@SuryanarayanaY Please feel free to add @vam-google for issues related to protobuf version mismatch.

@SuryanarayanaY SuryanarayanaY added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues TF 2.11 Issues related to TF 2.11 type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

6 participants