Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//tensorflow/python/util/protobuf:protobuf_compare_test fails with protobuf > 3.20.3 #59931

Open
elfringham opened this issue Mar 8, 2023 · 3 comments
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues type:bug Bug type:build/install Build and install issues

Comments

@elfringham
Copy link
Contributor

elfringham commented Mar 8, 2023

Click to expand!

Issue Type

Bug

Have you reproduced the bug with TF nightly?

Yes

Source

source

Tensorflow Version

git HEAD

Custom Code

No

OS Platform and Distribution

Ubuntu 20.04

Mobile device

n/a

Python version

3.9.16

Bazel version

5.3.0

GCC/Compiler version

9.4.0

CUDA/cuDNN version

n/a

GPU model and memory

n/a

Current Behaviour?

The test fails

Standalone code to reproduce the issue

bazel test --test_timeout=300,500,-1,-1 --flaky_test_attempts=3 --test_output=all --cache_test_results=no --noremote_accept_cached --test_env=TF_ENABLE_ONEDNN_OPTS=1 --build_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-requires-gpu --test_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-requires-gpu --verbose_failures --build_tests_only --jobs=16 -- //tensorflow/python/util/protobuf:protobuf_compare_test

Relevant log output

ERROR: testCheckInitialized (__main__.AssertTest)
AssertTest.testCheckInitialized
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.cache/bazel/_bazel_root/e953b164f58eb4c9598ad736d787ff39/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/util/protobuf/protobuf_compare_test.runfiles/org_tensorflow/tensorflow/python/util/protobuf/compare_test.py", line 324, in testCheckInitialized
    b = copy.deepcopy(a)
  File "/usr/lib/python3.9/copy.py", line 153, in deepcopy
    y = copier(memo)
  File "/usr/local/lib/python3.9/dist-packages/google/protobuf/message.py", line 83, in __deepcopy__
    clone.MergeFrom(self)
google.protobuf.message.EncodeError: Message compare_test.Labeled is missing required fields: required
@google-ml-butler google-ml-butler bot added the type:bug Bug label Mar 8, 2023
@SuryanarayanaY SuryanarayanaY added type:build/install Build and install issues subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues labels Mar 11, 2023
@SuryanarayanaY
Copy link
Collaborator

Hi @elfringham ,
I have replicated the reported test fail.The test fails with the error reported by you.

File "/home/suryanarayanay/.cache/bazel/_bazel_suryanarayanay/e93ef42332b258ebf8397106d59e39e3/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/util/protobuf/protobuf_compare_test.runfiles/org_tensorflow/tensorflow/python/util/protobuf/compare_test.py", line 324, in testCheckInitialized
  b = copy.deepcopy(a)
File "/home/suryanarayanay/miniconda3/envs/bazel/lib/python3.9/copy.py", line 153, in deepcopy
  y = copier(memo)
File "/home/suryanarayanay/miniconda3/envs/bazel/lib/python3.9/site-packages/google/protobuf/message.py", line 83, in __deepcopy__
  clone.MergeFrom(self)
google.protobuf.message.EncodeError: Message compare_test.Labeled is missing required fields: required

Also may please refer the logs attached below.

59931-logs.txt

@SuryanarayanaY
Copy link
Collaborator

CC - @learning-to-play

@learning-to-play
Copy link
Collaborator

Hi @SuryanarayanaY, Please feel free to add @vam-google for protobuf related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower subtype: ubuntu/linux Ubuntu/Linux Build/Installation Issues type:bug Bug type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

5 participants