Fix null pointer dereference in tsl::profiler::CreateStub #60221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name)
mihaimaruseac
approved these changes
Apr 4, 2023
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Apr 6, 2023
Imported from GitHub PR tensorflow/tensorflow#60221 The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) cc @mihaimaruseac Copybara import of the project: -- 232683a9b9e567f43239592b958e4302c257d85d by Alexey Vishnyakov <vishnya@ispras.ru>: Fix null pointer dereference in tsl::profiler::CreateStub The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) Merging this change closes #60221 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#60221 from SweetVishnya:rpc-profiler-client-nullptr 232683a9b9e567f43239592b958e4302c257d85d PiperOrigin-RevId: 522457456
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Apr 10, 2023
Imported from GitHub PR tensorflow/tensorflow#60221 The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) cc @mihaimaruseac Copybara import of the project: -- 232683a9b9e567f43239592b958e4302c257d85d by Alexey Vishnyakov <vishnya@ispras.ru>: Fix null pointer dereference in tsl::profiler::CreateStub The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) Merging this change closes #60221 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#60221 from SweetVishnya:rpc-profiler-client-nullptr 232683a9b9e567f43239592b958e4302c257d85d PiperOrigin-RevId: 522457456
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Apr 10, 2023
Imported from GitHub PR tensorflow/tensorflow#60221 The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) cc @mihaimaruseac Copybara import of the project: -- 232683a9b9e567f43239592b958e4302c257d85d by Alexey Vishnyakov <vishnya@ispras.ru>: Fix null pointer dereference in tsl::profiler::CreateStub The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) Merging this change closes #60221 PiperOrigin-RevId: 523138447
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Apr 10, 2023
Imported from GitHub PR tensorflow/tensorflow#60221 The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) cc @mihaimaruseac Copybara import of the project: -- 232683a9b9e567f43239592b958e4302c257d85d by Alexey Vishnyakov <vishnya@ispras.ru>: Fix null pointer dereference in tsl::profiler::CreateStub The bug was found by Svace static analyzer: 1. channel may be null 2. it is passed to grpc::ProfileAnalysis::NewStub(channel) 3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel) 4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name) Merging this change closes #60221 PiperOrigin-RevId: 523138447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was found by Svace static analyzer:
cc @mihaimaruseac