Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: nadam optimizer #7715

Closed
cancan101 opened this issue Feb 20, 2017 · 8 comments
Closed

Feature: nadam optimizer #7715

cancan101 opened this issue Feb 20, 2017 · 8 comments
Labels
stat:contribution welcome Status - Contributions welcome type:feature Feature requests

Comments

@cancan101
Copy link
Contributor

Adam with nesterov momentum.

Keras has it: https://keras.io/optimizers/#nadam
TF implementation (old and doesn't quite work) : https://github.com/tdozat/Optimization/blob/master/tensorflow/nadam.py

@inflation
Copy link
Contributor

I'm thinking about the same approach like MomentumOptimizer with a use_nesterov flag. But I don't know if it is still preferable to change the interface now.

@poxvoculi poxvoculi added the type:feature Feature requests label Feb 22, 2017
@poxvoculi
Copy link
Contributor

Is there a reason this shouldn't simply be a community supplied option, like the cited version? Are you suggesting a specific modification to TF? Otherwise perhaps it would be better to discuss such an extension on stack overflow.

@cancan101
Copy link
Contributor Author

@poxvoculi Do you think it makes sense to add a use_nesterov flag into Adam (in the tf repos)?

@poxvoculi
Copy link
Contributor

@ebrevdo: who would have an informed opinion on this?

@inflation
Copy link
Contributor

@poxvoculi A C++ implementation would be faster than python hacks like above. Also, maybe an awaiting googler label?

@ebrevdo
Copy link
Contributor

ebrevdo commented Feb 22, 2017 via email

@poxvoculi poxvoculi added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Feb 22, 2017
@poxvoculi poxvoculi reopened this Feb 22, 2017
@vincentvanhoucke
Copy link
Contributor

Plausible. I have no experience with it. If someone implements it, it sounds like something we would incorporate.

@girving
Copy link
Contributor

girving commented Jun 16, 2017

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@girving girving closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:contribution welcome Status - Contributions welcome type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

6 participants