Fix Cuda configuration on Windows #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a genrule for a set of files, we use copy instead of symlink on Windows. Applied the same approach to python_config.bzl to simplify the code.
maciekcc
reviewed
May 25, 2017
| @@ -67,4 +67,4 @@ passing_tests=$(bazel query "kind(py_test, //${PY_TEST_DIR}/tensorflow/python/. | |||
| # Define no_tensorflow_py_deps=true so that every py_test has no deps anymore, | |||
| # which will result testing system installed tensorflow | |||
| # GPU tests are very flaky when running concurently, so set local_test_jobs=5 | |||
There was a problem hiding this comment.
nit: please update comment to reflect the change in script.
|
Jenkins test this please. |
maciekcc
reviewed
May 26, 2017
third_party/gpus/cuda_configure.bzl
Outdated
|
|
||
| If src_dir is passed, files will be read from the given directory; otherwise | ||
| we assume files are in src_files and dest_files | ||
| """ | ||
| if src_dir != None: | ||
| src_dir = src_dir.replace("\\", "/") | ||
| dest_dir = dest_dir.replace("\\", "/") |
There was a problem hiding this comment.
One more nit: can you please extract a method to perform this path slash replacement and trimming, and then use it in both the files.
maciekcc
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a genrule for a set of files, we should use copy instead of
symlink on Windows.
This addresses an error reported at stackoverflow:
https://stackoverflow.com/questions/44038367/genrules-without-outputs-dont-make-sense-bazel-windows-10-build
Applied the same approach to python_config.bzl to simplify the code.