Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support for trigonometric operations #1108

Closed
fxsuper opened this issue Feb 15, 2016 · 9 comments
Closed

Basic support for trigonometric operations #1108

fxsuper opened this issue Feb 15, 2016 · 9 comments
Labels
stat:contribution welcome Status - Contributions welcome type:feature Feature requests

Comments

@fxsuper
Copy link

fxsuper commented Feb 15, 2016

I'd like to request support for basic trigonometric ops. Nothing fancy, but just simple stuff like tan and the arc complement (arcsin, arctan, etc). All that's there right now is sin and cos.
@martinwicke martinwicke added enhancement stat:contribution welcome Status - Contributions welcome labels Feb 16, 2016
@martinwicke
Copy link
Member

And, of course, tanh. :)

That's a good idea.

@girving
Copy link
Contributor

girving commented Feb 16, 2016

Also all the hyperbolic trig functions.

Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 16, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions tensorflow#1108
bca83df
@Mistobaan Mistobaan mentioned this issue Feb 16, 2016
Closed
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 16, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions tensorflow#1108
ce4c5c3
@Mistobaan
Copy link
Contributor

I gave a shot at implementing the first ones.

@fxsuper
Copy link
Author

fxsuper commented Feb 16, 2016

#483 is related as well.

@girving
Copy link
Contributor

girving commented Feb 16, 2016

#483 is probably separate since it involves a dtype change, and can't participate in the same pile of macros.

@fxsuper
Copy link
Author

fxsuper commented Feb 18, 2016

I guess atan2 would get us part of the way there. Perhaps it can be included with the other elementary trig functions?

Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 22, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions tensorflow#1108
53a1317
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 22, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions tensorflow#1108
32b692b
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 22, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions tensorflow#1108
667f29f
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 22, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
694831e
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Feb 22, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
5de9478
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 5, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
01d0b05
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 5, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
74814f3
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 7, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
5f8ce85
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 18, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
8fb48a1
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 21, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
4cf8d0d
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Mar 21, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
9fc2b47
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue Apr 21, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
3a81c12
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue May 14, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
2e50899
Mistobaan added a commit to Mistobaan/tensorflow that referenced this issue May 28, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See tensorflow#1108
8ef293a 
note: these functions are not implemented for eigen::half, complex64 and complex128
vrv pushed a commit that referenced this issue May 29, 2016
@Mistobaan
Add Tan, Asin, Acos, Atan trigonometric functions. See #1108 (#1573)
da88903 
note: these functions are not implemented for eigen::half, complex64 and complex128
@webmaven
Copy link

Can this issue be closed? It looks like changes (in PR #1573) were merged into master back in May.

@vrv
Copy link

vrv commented Oct 26, 2016

Sure!

@vrv vrv closed this as completed Oct 26, 2016
@aselle aselle added the type:feature Feature requests label Feb 9, 2017
@aselle aselle removed the enhancement label Feb 9, 2017
@SystemErrorWang
Copy link

Hope these functions can support batch input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:contribution welcome Status - Contributions welcome type:feature Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@girving @Mistobaan @aselle @webmaven @vrv @martinwicke @fxsuper @SystemErrorWang