New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `.idea/**` into .gitignore for JetBrains IDE #12094

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
5 participants
@asdf2014
Contributor

asdf2014 commented Aug 8, 2017

We usually use PyCharm for reading the source code of Tensorflow, so it is necessary for most developers to add .idea/** into .gitignore for JetBrains IDE to ignore those non-project files.

@mention-bot

This comment has been minimized.

mention-bot commented Aug 8, 2017

@asdf2014, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tensorflower-gardener, @benoitsteiner and @keveman to be potential reviewers.

@googlebot

This comment has been minimized.

googlebot commented Aug 8, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no label Aug 8, 2017

@asdf2014

This comment has been minimized.

Contributor

asdf2014 commented Aug 8, 2017

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Aug 8, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 8, 2017

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Aug 8, 2017

@tensorflow-jenkins test this please

@rmlarsen rmlarsen self-assigned this Aug 9, 2017

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Aug 9, 2017

@tensorflow-jenkins test this please

2 similar comments
@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Aug 9, 2017

@tensorflow-jenkins test this please

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Aug 9, 2017

@tensorflow-jenkins test this please

@rmlarsen rmlarsen merged commit 45207a0 into tensorflow:master Aug 9, 2017

3 of 11 checks passed

MacOS CPU Tests FAILURE
Details
Android Demo App BUILDING
Details
Linux CPU Tests BUILDING
Details
Linux CPU Tests (Python 3) BUILDING
Details
Linux GPU BUILDING
Details
Linux XLA BUILDING
Details
Windows Cmake Tests BUILDING
Details
ci.tensorflow.org BUILDING
Details
Linux CPU Tests Makefile SUCCESS
Details
Sanity Checks SUCCESS
Details
cla/google All necessary CLAs are signed
@cancan101

This comment has been minimized.

Contributor

cancan101 commented Aug 9, 2017

I think is generally not best practice to add IDE specific rules to a project gitignore. Rather have the developer use a global gitignore on his/her system. See for example: joeblau/gitignore.io#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment