r1.3 fix Bazel 0.5.3 build error #12248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bazel 0.5.3 (cherry picked from commit c5d311e)
|
Can one of the admins verify this patch? |
|
@ahundt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tensorflower-gardener, @andrewharp and @rohan100jain to be potential reviewers. |
This was referenced Aug 13, 2017
|
Jenkins, test this please. |
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the patch necessary for TensorFlow r1.3 to compile with Bazel 0.5.3, which is set to be merged before the 1.3 release.
@martinwicke Mentioned in #11949 (comment) from which this change is cherry picked:
I can confirm it isn't on the 1.3 branch. I'm building on Bazel 0.5.3, and I can also confirm that the r1.3 build works locally on my Ubuntu 16.04 once this patch is added, but does not work without it.
change description:
Fix "depsets cannot contain mutable items" error with CUDA builds in Bazel 0.5.3"
(cherry picked from commit c5d311e)