Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: C++ gradient for LRN #13987

Merged
merged 10 commits into from
Nov 30, 2017
Merged

Feature Request: C++ gradient for LRN #13987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4f471fc
WIP: added stub method and failing test
gdeer81 Oct 18, 2017
cc147b2
test with default bias,alpha,beta,depth_radius passes
gdeer81 Oct 24, 2017
7f226b3
Made changes based on code review
gdeer81 Oct 24, 2017
710c801
Fixed call to LRNGrad with proper namespace
gdeer81 Oct 24, 2017
e59f0f5
fixed function call to LRNGrad, all tests pass somehow
gdeer81 Oct 25, 2017
c1a9a21
fixed function call to LRNGrad, tests pass
gdeer81 Oct 26, 2017
06c2bba
minor formatting changes based on clang-format suggestions
gdeer81 Oct 26, 2017
3552980
Merge branch 'master' of https://github.com/tensorflow/tensorflow
gdeer81 Oct 26, 2017
3b940ab
formatting changes and updated test based on code review
gdeer81 Nov 4, 2017
e8e3b3d
trimmed the tensor shape to prevent test timeout
gdeer81 Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions tensorflow/cc/gradients/nn_grad.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,18 @@ Status MaxPoolGradV2Helper(const Scope& scope, const Operation& op,
}
REGISTER_GRADIENT_OP("MaxPoolV2", MaxPoolGradV2Helper);

Status LRNGradHelper(const Scope& scope, const Operation& op,
const std::vector<Output>& grad_inputs,
std::vector<Output>* grad_outputs){
internal::LRNGrad::Attrs grad_attrs;

auto dx = internal::LRNGrad(scope, grad_inputs[0], op.input(0), op.output(0),
grad_attrs);
grad_outputs->push_back(dx);
return scope.status();
}
REGISTER_GRADIENT_OP("LRN", LRNGradHelper);

} // anonymous namespace
} // namespace ops
} // namespace tensorflow
7 changes: 7 additions & 0 deletions tensorflow/cc/gradients/nn_grad_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,5 +191,12 @@ TEST_F(NNGradTest, MaxPoolGradV2Helper) {
RunTest(x, x_init_value, y, y_shape);
}

TEST_F(NNGradTest, LRN){
TensorShape x_shape({1, 1, 2, 1});
auto x = Placeholder(scope_, DT_FLOAT, Placeholder::Shape(x_shape));
auto y = LRN(scope_, x);
RunTest(x, x_shape, y, x_shape);
}

} // namespace
} // namespace tensorflow