-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos in comments #14399
Fixed typos in comments #14399
Conversation
Can one of the admins verify this patch? |
@@ -1,7 +1,7 @@ | |||
// Protocol buffers for saved tensor slices. It's used for the brain tensor | |||
// ops checkpoints and the V3 checkpoints in dist_belief. | |||
|
|||
// A checkpoint file is an sstable. The value for each record is a serialized | |||
// A checkpoint file is a stable. The value for each record is a serialized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original should be right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
@@ -218,8 +218,8 @@ Status ValidateStridedSliceOp( | |||
|
|||
// Step 2: Make a sparse spec into a full index spec | |||
// | |||
// The sparse spec does not corresopnds to the number of dimensions | |||
// Make a dense spec that corresponds to thte number of dimensions | |||
// The sparse spec does not corresponds to the number of dimensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No "s" at the end of "correspond".
// The sparse spec does not corresopnds to the number of dimensions | ||
// Make a dense spec that corresponds to thte number of dimensions | ||
// The sparse spec does not correspond to the number of dimensions | ||
// Make a dense spec that correspond to the number of dimensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"corresponds" here :-)
Jenkins, test this please |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
No description provided.