Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update label_image.py #15022

Merged
merged 3 commits into from Jan 10, 2018
Merged

update label_image.py #15022

merged 3 commits into from Jan 10, 2018

Conversation

freedomtan
Copy link
Contributor

  1. add build rule for label_image.py
  2. remove extraneous semicolons

add label_image_py to BUILD and update README.md accordingly
@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@sb2nov
Copy link
Contributor

sb2nov commented Dec 1, 2017

@gunan the buildifier error seems to be suggesting a noop. What does that mean?

@@ -51,6 +51,16 @@ tf_cc_binary(
}),
)

py_binary(
name = "label_image_py",
main = "label_image.py",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main should come after srcs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh interesting. @freedomtan can you change that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sb2nov done.

@gunan
Copy link
Contributor

gunan commented Dec 1, 2017

Jenkins, test this please.

1 similar comment
@drpngx
Copy link
Contributor

drpngx commented Dec 4, 2017

Jenkins, test this please.

@drpngx drpngx added kokoro:force-run Tests on submitted change awaiting review Pull request awaiting review labels Dec 4, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 4, 2017
@drpngx
Copy link
Contributor

drpngx commented Dec 29, 2017

@gunan good to go if build passes?

@drpngx drpngx added awaiting testing (then merge) and removed awaiting review Pull request awaiting review labels Jan 7, 2018
@drpngx
Copy link
Contributor

drpngx commented Jan 7, 2018

Jenkins, test this please.

@drpngx drpngx added the kokoro:force-run Tests on submitted change label Jan 7, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 7, 2018
@drpngx
Copy link
Contributor

drpngx commented Jan 7, 2018

@caisq looks like there are some failures on master, right?

@caisq
Copy link
Contributor

caisq commented Jan 7, 2018

Some of the failures do not seem to be existing on master. For example this one:
http://ci.tensorflow.org/job/tensorflow-pull-requests-cpu-python3/7941/consoleFull

This one points to a nonexistent page:
https://ci.tensorflow.org/job/tensorflow-pull-requests-xla/4108/

These looks strange, but I don't see them on Jenkins:
https://source.cloud.google.com/results/invocations/c8affece-3a4b-4eae-af9b-2593c0ffcae1/targets

Triggering test again.

@tensorflow-jenkins test this please

@caisq caisq added the kokoro:force-run Tests on submitted change label Jan 7, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 7, 2018
@drpngx
Copy link
Contributor

drpngx commented Jan 7, 2018

If the test doesn't refresh and the link is broken then it's probably an old Jenkins target that was moved to kokoro.

@drpngx
Copy link
Contributor

drpngx commented Jan 9, 2018

Some tests appear to fail. I'm not sure they are related. Could you check?

@freedomtan
Copy link
Contributor Author

I don't think those failures are relevant. Anything I can do to clarify it?

@caisq
Copy link
Contributor

caisq commented Jan 10, 2018

@freedomtan The test failures are unrelated. Mergin PR. Thanks.

@caisq caisq merged commit 25d2752 into tensorflow:master Jan 10, 2018
@freedomtan freedomtan deleted the label_image branch January 11, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants