New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update label_image.py #15022
update label_image.py #15022
Conversation
freedomtan
commented
Dec 1, 2017
- add build rule for label_image.py
- remove extraneous semicolons
add label_image_py to BUILD and update README.md accordingly
Can one of the admins verify this patch? |
@gunan the buildifier error seems to be suggesting a noop. What does that mean? |
@@ -51,6 +51,16 @@ tf_cc_binary( | |||
}), | |||
) | |||
|
|||
py_binary( | |||
name = "label_image_py", | |||
main = "label_image.py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main should come after srcs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh interesting. @freedomtan can you change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sb2nov done.
Jenkins, test this please. |
1 similar comment
Jenkins, test this please. |
@gunan good to go if build passes? |
Jenkins, test this please. |
@caisq looks like there are some failures on master, right? |
Some of the failures do not seem to be existing on master. For example this one: This one points to a nonexistent page: These looks strange, but I don't see them on Jenkins: Triggering test again. @tensorflow-jenkins test this please |
If the test doesn't refresh and the link is broken then it's probably an old Jenkins target that was moved to kokoro. |
Some tests appear to fail. I'm not sure they are related. Could you check? |
I don't think those failures are relevant. Anything I can do to clarify it? |
@freedomtan The test failures are unrelated. Mergin PR. Thanks. |