Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static shape inference for keras.layers.LSTM #15234

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions tensorflow/python/keras/_impl/keras/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -2668,6 +2668,7 @@ def rnn(step_function,
ndim = len(inputs.get_shape())
if ndim < 3:
raise ValueError('Input should be at least 3D.')
inputs_shape = inputs.get_shape()
axes = [1, 0] + list(range(2, ndim))
inputs = array_ops.transpose(inputs, (axes))

Expand Down Expand Up @@ -2852,6 +2853,13 @@ def _step(time, output_ta_t, *states):

axes = [1, 0] + list(range(2, len(outputs.get_shape())))
outputs = array_ops.transpose(outputs, axes)

# Static shape inference: (samples, time, ...)
outputs_shape = outputs.get_shape().as_list()
outputs_shape[0] = inputs_shape[0]
outputs_shape[1] = inputs_shape[1]
outputs.set_shape(outputs_shape)

last_output._uses_learning_phase = uses_learning_phase
return last_output, outputs, new_states

Expand Down
9 changes: 9 additions & 0 deletions tensorflow/python/keras/_impl/keras/backend_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -907,6 +907,15 @@ def step_function(x, states):
last_output, outputs, new_states = keras.backend.rnn(rnn_fn, inputs,
initial_states,
**kwargs)
# check static shape inference
self.assertEquals(last_output.get_shape().as_list(),
[num_samples, output_dim])
self.assertEquals(outputs.get_shape().as_list(),
[num_samples, timesteps, output_dim])
for state in new_states:
self.assertEquals(state.get_shape().as_list(),
[num_samples, output_dim])

last_output_list[i].append(keras.backend.eval(last_output))
outputs_list[i].append(keras.backend.eval(outputs))
self.assertEqual(len(new_states), 1)
Expand Down
17 changes: 17 additions & 0 deletions tensorflow/python/keras/_impl/keras/layers/lstm_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,23 @@ def test_return_sequences_LSTM(self):
'return_sequences': True},
input_shape=(num_samples, timesteps, embedding_dim))

def test_static_shape_inference_LSTM(self):
# Github issue: 15165
num_samples = 2
timesteps = 3
embedding_dim = 4
units = 2

model = keras.models.Sequential()
inputs = keras.layers.Dense(embedding_dim,
input_shape=(timesteps, embedding_dim))
model.add(inputs)
layer = keras.layers.LSTM(units, return_sequences=True)
model.add(layer)
outputs = model.layers[-1].output
self.assertEquals(outputs.get_shape().as_list(),
[None, timesteps, units])

def test_dynamic_behavior_LSTM(self):
num_samples = 2
timesteps = 3
Expand Down