-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add int64 support for BroadcastArgs and BroadcastGradientArgs #15255
Merged
drpngx
merged 3 commits into
tensorflow:master
from
yongtang:12102017-BroadcastArgs-int64
Dec 27, 2017
Merged
Add int64 support for BroadcastArgs and BroadcastGradientArgs #15255
drpngx
merged 3 commits into
tensorflow:master
from
yongtang:12102017-BroadcastArgs-int64
Dec 27, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `array_ops.cc`, both int32 and int64 are expected to be supported for `BroadcastArgs` and `BroadcastGradientArgs`. However, this was not the case as only int32 kernel are registered even though `T` is part of the `TypeConstraint`. This fix adds the int64 kernel support for `BroadcastArgs` and `BroadcastGradientArgs`, and adds related test cases. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…ntArgs Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
12102017-BroadcastArgs-int64
branch
from
December 11, 2017 01:52
165534f
to
22660ae
Compare
Jenkins, test this please. |
vrv
approved these changes
Dec 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
drpngx
added
awaiting testing (then merge)
and removed
awaiting review
Pull request awaiting review
labels
Dec 26, 2017
Flaky test?
|
Jenkins, test this please. |
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
array_ops.cc
, both int32 and int64 are expected to be supported forBroadcastArgs
andBroadcastGradientArgs
. However, this was not the case as only int32 kernel are registered even thoughT
is part of theTypeConstraint
.This fix adds the int64 kernel support for
BroadcastArgs
andBroadcastGradientArgs
, and adds related test cases.Signed-off-by: Yong Tang yong.tang.github@outlook.com