Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int64 support for BroadcastArgs and BroadcastGradientArgs #15255

Merged
merged 3 commits into from
Dec 27, 2017

Conversation

yongtang
Copy link
Member

In array_ops.cc, both int32 and int64 are expected to be supported for BroadcastArgs and BroadcastGradientArgs. However, this was not the case as only int32 kernel are registered even though T is part of the TypeConstraint.

This fix adds the int64 kernel support for BroadcastArgs and BroadcastGradientArgs, and adds related test cases.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

In `array_ops.cc`, both int32 and int64 are expected to be supported
for `BroadcastArgs` and `BroadcastGradientArgs`. However, this was
not the case as only int32 kernel are registered even though `T`
is part of the `TypeConstraint`.

This fix adds the int64 kernel support for `BroadcastArgs` and
`BroadcastGradientArgs`, and adds related test cases.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…ntArgs

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@drpngx drpngx requested a review from vrv December 26, 2017 02:31
@drpngx drpngx added the awaiting review Pull request awaiting review label Dec 26, 2017
@drpngx
Copy link
Contributor

drpngx commented Dec 26, 2017

Jenkins, test this please.

Copy link

@vrv vrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drpngx drpngx added awaiting testing (then merge) and removed awaiting review Pull request awaiting review labels Dec 26, 2017
@drpngx
Copy link
Contributor

drpngx commented Dec 26, 2017

Flaky test?

E1211 01:58:36.775779505      15 server_chttp2.cc:38]        {"created":"@1512957516.775699432","description":"No address added out of total 1 resolved","file":"external/grpc/src/core/ext/transport/chttp2/server/chttp2_server.cc","file_line":248,"referenced_errors":[{"created":"@1512957516.775696170","description":"Failed to add any wildcard listeners","file":"external/grpc/src/core/lib/iomgr/tcp_server_posix.cc","file_line":340,"referenced_errors":[{"created":"@1512957516.775683269","description":"Unable to configure socket","fd":13,"file":"external/grpc/src/core/lib/iomgr/tcp_server_utils_posix_common.cc","file_line":200,"referenced_errors":[{"created":"@1512957516.775666688","description":"OS Error","errno":98,"file":"external/grpc/src/core/lib/iomgr/tcp_server_utils_posix_common.cc","file_line":173,"os_error":"Address already in use","syscall":"bind"}]},{"created":"@1512957516.775695307","description":"Unable to configure socket","fd":13,"file":"external/grpc/src/core/lib/iomgr/tcp_server_utils_posix_common.cc","file_line":200,"referenced_errors":[{"created":"@1512957516.775691914","description":"OS Error","errno":98,"file":"external/grpc/src/core/lib/iomgr/tcp_server_utils_posix_common.cc","file_line":173,"os_error":"Address already in use","syscall":"bind"}]}]}]}
E.s...............
======================================================================
ERROR: testRemoteFunctionCrossProcess (__main__.FunctionalOpsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/python/kernel_tests/functional_ops_test.runfiles/org_tensorflow/tensorflow/python/kernel_tests/functional_ops_test.py", line 588, in testRemoteFunctionCrossProcess
    workers, _ = test_util.create_local_cluster(2, 1)
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/python/kernel_tests/functional_ops_test.runfiles/org_tensorflow/tensorflow/python/framework/test_util.py", line 1298, in create_local_cluster
    for ix in range(num_ps)
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/python/kernel_tests/functional_ops_test.runfiles/org_tensorflow/tensorflow/python/framework/test_util.py", line 1298, in <listcomp>
    for ix in range(num_ps)
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/python/kernel_tests/functional_ops_test.runfiles/org_tensorflow/tensorflow/python/training/server_lib.py", line 145, in __init__
    self._server_def.SerializeToString(), status)
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/python/kernel_tests/functional_ops_test.runfiles/org_tensorflow/tensorflow/python/framework/errors_impl.py", line 473, in __exit__
    c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.UnknownError: Could not start gRPC server

----------------------------------------------------------------------
Ran 39 tests in 2.226s

@drpngx
Copy link
Contributor

drpngx commented Dec 26, 2017

Jenkins, test this please.

@drpngx drpngx added the kokoro:force-run Tests on submitted change label Dec 26, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 26, 2017
@drpngx
Copy link
Contributor

drpngx commented Dec 27, 2017

Jenkins, test this please.

@drpngx drpngx merged commit f190c23 into tensorflow:master Dec 27, 2017
@yongtang yongtang deleted the 12102017-BroadcastArgs-int64 branch December 27, 2017 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants