Fix #15297: bfloat16 is unsigned on Windows #15302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This PR depends on #14531. |
|
@guschmue , do you still working on gemmlowp port? |
|
the pr for gemmlowp windows support was recently merged and a pr to enable quantization ops for windows was merged as well. |
hawkinsp
approved these changes
Dec 13, 2017
|
@tensorflow-jenkins Test this please |
|
dnn_linear_combined_test is also failing in the trunk. It's not due to this change. We may think all the tests were passed. |
gunan
approved these changes
Dec 18, 2017
|
Looks like this PR is causing a breakage: http://ci.tensorflow.org/job/tf-master-win-bzl/2088/console |
|
Yes. I updating #14531 |
This was referenced Dec 19, 2017
av8ramit
pushed a commit
to av8ramit/tensorflow
that referenced
this pull request
Dec 27, 2017
This reverts commit fdf34a8.
av8ramit
pushed a commit
that referenced
this pull request
Dec 27, 2017
meteorcloudy
added a commit
to meteorcloudy/tensorflow
that referenced
this pull request
Jan 3, 2018
This reverts commit fdf34a8.
caisq
added a commit
that referenced
this pull request
Jan 3, 2018
Revert "Fix a bug: bfloat16 is unsigned on Windows (#15302)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15297
BYTE_ORDER is not a builtin macro in VC++. Need to include "tensorflow/core/platform/cpu_info.h" before using it.