Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of "option" use "set" to define non-bool cmake build args. #15372

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Instead of "option" use "set" to define non-bool cmake build args. #15372

merged 1 commit into from
Dec 15, 2017

Conversation

gunan
Copy link
Contributor

@gunan gunan commented Dec 14, 2017

No description provided.

@gunan gunan requested a review from mrry December 14, 2017 21:20
mrry
mrry approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@mrry mrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it ;).

@gunan
Copy link
Contributor Author

gunan commented Dec 15, 2017

http://ci.tensorflow.org/view/TF%20pull%20requests/job/tf-pr-win-cmake-gpu/22/console

The job was able to correctly parse the cmakefile.

@gunan gunan merged commit 798fa36 into tensorflow:master Dec 15, 2017
@gunan gunan deleted the cmake branch December 15, 2017 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrry mrry mrry approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gunan @mrry @googlebot