Complete the loop before returning the words #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop now completes before returning the words, 'with' is used to make sure the file closes and the description of the function now describes that it returns a list of words, not a string.
|
As noted in our contributing.md, currently our changes have to go through gerrit. Closing for now, thanks! |
tarasglek
pushed a commit
to tarasglek/tensorflow
that referenced
this pull request
Jun 20, 2017
…put size (tensorflow#155) * Changed the examples to specify the output size instead of the downsample_factor. This is required by PR tensorflow#57 * Address flake8 errors. * Update readme and parameter descriptions.
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 19, 2019
Closes #155 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#155 from Robertorosmaninho:patch-1 232ac4e1253948c7f3150515e93abe50fcec2f96 PiperOrigin-RevId: 271876515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop now completes before returning the words, 'with' is used to make sure the file closes and the description of the function now describes that it returns a list of words, not a string.