Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add broadcasting support for tf.where #15982

Merged
merged 23 commits into from
May 7, 2019
Merged

Add broadcasting support for tf.where #15982

merged 23 commits into from
May 7, 2019

Commits on Nov 6, 2018

  1. Add broadcasting support for tf.where 

    This fix tries to address the issue raised in 9284 where
there was no broadcasting support for `tf.where`. This
fix adds the support so that the behavior of `tf.where`
matches `np.where`.

This fix fixes 9284.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    eb856d1 View commit details
    Browse the repository at this point in the history

  2. Update shape function for tf.where / SelectOp 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5cb7665 View commit details
    Browse the repository at this point in the history

  3. Add template for BCastSelectFunctor 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5ce52a0 View commit details
    Browse the repository at this point in the history

  4. Add GPU support for where_v2 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    94b1e3e View commit details
    Browse the repository at this point in the history

  5. Add test case for broadcasting support of where_v2 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    2250c49 View commit details
    Browse the repository at this point in the history

  6. Define where_v2 in array_ops.py 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    399d5c2 View commit details
    Browse the repository at this point in the history

  7. Add broadcasting support for tf.where 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    75b4505 View commit details
    Browse the repository at this point in the history

  8. Fix Experimental clang-format Check 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    0ec97a7 View commit details
    Browse the repository at this point in the history

  9. Update api compatibility test 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    e5edd77 View commit details
    Browse the repository at this point in the history

  10. Update api_def 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    ab4f60d View commit details
    Browse the repository at this point in the history

  11. Add additional test case for tf.where_v2, based on review feedback 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    7a9fd72 View commit details
    Browse the repository at this point in the history

  12. Fix broken tests 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    fec417d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Merge branch 'master' into 9284-tf.where-broadcasting

    @martinwicke
    martinwicke committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    0d2c28c View commit details
    Browse the repository at this point in the history

  2. Expose where_v2 as v1=["where_v2"], v2=["where"] 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    e1f2b7c View commit details
    Browse the repository at this point in the history

  3. Add deprecation to tf.where 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ad970c3 View commit details
    Browse the repository at this point in the history

  4. Hide select_v2 API 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    4059b95 View commit details
    Browse the repository at this point in the history

  5. Update api goldens 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    bc3538f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Update API to use @tf_export(v1=["where"]) for legacy where, and @t… 

    …f_export("where", v1=["where_v2"]) for new `where`

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    8d198f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. Merge branch 'master' into 9284-tf.where-broadcasting

    @yongtang
    yongtang committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    56aa488 View commit details
    Browse the repository at this point in the history

  2. Update api compat and tf_upgrade_v2 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    70e39f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Rename tf.where_v2 to tf.compat.v2.where, as rename script has to 

    work in v1 and v2 so explicitly specifying tf.compat.v2.where
(from review comment).

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    d9b98c4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Rename elem_bcast to then_else_bcast, and remove duplicate template s… 

    …pecification

based on review comment.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed May 2, 2019
    Configuration menu
    Copy the full SHA
    e75409c View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Fix GPU build failure 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed May 3, 2019
    Configuration menu
    Copy the full SHA
    33cd7b8 View commit details
    Browse the repository at this point in the history