Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating point exception when loading from a small events log file using the loader #17692

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Fix floating point exception when loading from a small events log file using the loader #17692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584e349
Fix floating point exception with bps calculation
skambha Mar 13, 2018
548415b
Use the same log line for bps and also report bps when elapsed is 0
skambha Mar 29, 2018
b621ac0
Add the commas back
skambha Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions tensorflow/contrib/tensorboard/db/loader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ int main(int argc, char* argv[]) {
++records;
}
uint64 elapsed = env->NowMicros() - start;
uint64 bps = (elapsed == 0 ? offset : static_cast<uint64>(
offset / (elapsed / 1000000.0)));
LOG(INFO) << "Loaded " << AddCommas(offset) << " bytes with "
<< AddCommas(records) << " records at "
<< AddCommas(offset / (elapsed / 1000000)) << " bps";

<< AddCommas(records) << " records at " << AddCommas(bps) << " bps";
return 0;
}

Expand Down