-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix print function with tf_logging.info to keep consistence #18423
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
94e9890
Fix print function with tf_logging.info to keep consistence
imsheridan 02ab99d
fix minor typo
imsheridan 5fe3414
fix pylint errors
imsheridan 44e7243
Merge branch 'master' into fix_print_func
jhseu 04ac89f
Fix minor pylint errors
imsheridan ba8fe5c
Fix lint error
jhseu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -947,7 +947,7 @@ def _ConstructAndTestGradient(self, | |
output_sizes, | ||
x_init_value=x_init_value, | ||
delta=1e-2) | ||
print("%s gradient error = " % func_name, err) | ||
tf_logging.info("%s gradient error = " % func_name, err) | ||
self.assertLess(err, err_tolerance) | ||
|
||
def _ConstructAndTestSecondGradient(self, | ||
|
@@ -1024,7 +1024,7 @@ def _ConstructAndTestSecondGradient(self, | |
input_sizes, | ||
x_init_value=x_init_value, | ||
delta=1e-2) | ||
print("%s second-order gradient error = " % func_name, err) | ||
tf_logging.info("%s second-order gradient error = " % func_name, err) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be: |
||
self.assertLess(err, err_tolerance) | ||
|
||
def _testMaxPoolGradValidPadding1_1(self, data_format, use_gpu): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is broken, should be:
tf_logging.info("%s gradient error = %.4f" % (func_name, err))